Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DD04218E2A for ; Fri, 1 May 2015 00:45:20 +0000 (UTC) Received: (qmail 71498 invoked by uid 500); 1 May 2015 00:45:20 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 71467 invoked by uid 500); 1 May 2015 00:45:20 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 71452 invoked by uid 99); 1 May 2015 00:45:20 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 01 May 2015 00:45:20 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 46CDD1DBB35; Fri, 1 May 2015 00:45:20 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0373924618332186632==" MIME-Version: 1.0 Subject: Review Request 33741: Kerberos Identity data is empty when Cluster.security_type != KERBEROS From: "Robert Levas" To: "Emil Anca" , "Yusaku Sako" , "Robert Nettleton" Cc: "Robert Levas" , "Ambari" Date: Fri, 01 May 2015 00:45:20 -0000 Message-ID: <20150501004520.1509.54121@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Robert Levas" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/33741/ X-Sender: "Robert Levas" Reply-To: "Robert Levas" X-ReviewRequest-Repository: ambari --===============0373924618332186632== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33741/ ----------------------------------------------------------- Review request for Ambari, Emil Anca, Robert Nettleton, and Yusaku Sako. Bugs: AMBARI-10875 https://issues.apache.org/jira/browse/AMBARI-10875 Repository: ambari Description ------- Kerberos Identity data is empty when Cluster.security_type does not equal "KERBEROS". Technically this seems to make sense since there shouldn't be any relevant Kerberos identities if the cluster isn't configured for Kerberos; however a _chicken-and-the-egg_ condition is encountered when manually enabled Kerberos and a listing of the needed Kerberos identities is needed before Kerberos is to be fully enabled. **Solution** Allow the keberos_identities API end points to generate data even if Cluster.security_type is not equal to "KERBEROS". Diffs ----- ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java b131c4c ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java 614ee57 Diff: https://reviews.apache.org/r/33741/diff/ Testing ------- Manual testing **Jenkins test results: PENDING** Thanks, Robert Levas --===============0373924618332186632==--