ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AMBARI-11566) Alert Definition Source Field Has Numerical Values Converted To Strings On Creation Or Update
Date Sun, 31 May 2015 15:18:17 GMT

    [ https://issues.apache.org/jira/browse/AMBARI-11566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14566583#comment-14566583
] 

Hadoop QA commented on AMBARI-11566:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12736427/AMBARI-11566.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified
test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in ambari-server:

                  org.apache.ambari.server.orm.dao.AlertsDAOTest

Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/2948//testReport/
Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/2948//console

This message is automatically generated.

> Alert Definition Source Field Has Numerical Values Converted To Strings On Creation Or
Update
> ---------------------------------------------------------------------------------------------
>
>                 Key: AMBARI-11566
>                 URL: https://issues.apache.org/jira/browse/AMBARI-11566
>             Project: Ambari
>          Issue Type: Bug
>          Components: ambari-server
>    Affects Versions: 2.0.0
>            Reporter: Jonathan Hurley
>            Assignee: Jonathan Hurley
>             Fix For: 2.1.0
>
>         Attachments: AMBARI-11566.patch
>
>
> When creating or updating an alert definition from the API, any numerical values in the
{{source}} element are converted into {{String}} and stored in the database as such. This
causes de-serialization problems for definitions on Ambari Server restart.
> The problem stems from how Ambari converts the JSON body to a Map inside of {{JsonRequestBodyParser}}.
This uses a {{Map<String,String>}} instead of a {{Map<String,Object>}}. As a result,
the {{JsonObject}} has it's {{asText()}} method used to retrieve the value.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message