ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alejandro Fernandez" <afernan...@hortonworks.com>
Subject Re: Review Request 34723: RU: Storm actions require Zookeeper host
Date Wed, 27 May 2015 18:27:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34723/#review85406
-----------------------------------------------------------



ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/storm_upgrade.py
<https://reviews.apache.org/r/34723/#comment136957>

    Won't this raise an exception trying to get the value if it's not in the config dictionary?
    Perhaps params.storm_zookeeper_servers should still use the default(..., None) notation.



ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/storm_upgrade.py
<https://reviews.apache.org/r/34723/#comment136958>

    If it fails on all ZK clients then no exception will be raised.



ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/yaml_utils.py
<https://reviews.apache.org/r/34723/#comment136959>

    Can we move this to ambari-common?


- Alejandro Fernandez


On May 27, 2015, 6:10 p.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34723/
> -----------------------------------------------------------
> 
> (Updated May 27, 2015, 6:10 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Nate Cole.
> 
> 
> Bugs: AMBARI-11438
>     https://issues.apache.org/jira/browse/AMBARI-11438
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Two Storm issues occurred during HDP-2.2 -> HDP-2.3 RU, both the same issue.  Occurs
when the Storm packages are NOT on the same host as any zookeeper servers.
> 
> * Nimbus prepare invokes a zkCli.sh command to remove /storm
> * Storm service check appears to have the same issue when not on the ZK servers.
> 
> The solution here is to use the zookeeper servers property from storm-site and pass in
-server to zkCli.sh
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py
5ae7170 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/storm_upgrade.py
b25cdf8 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/yaml_utils.py
7b71553 
>   ambari-server/src/test/python/stacks/2.3/STORM/test_yaml_utils.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/34723/diff/
> 
> 
> Testing
> -------
> 
> Upgraded storm with Nimbus on a host that did not have ZK.
> 
> ----------------------------------------------------------------------
> Total run:744
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message