ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Hurley" <jhur...@hortonworks.com>
Subject Re: Review Request 34712: ambari-agent.out file grows geometrically and quickly fills up disk
Date Wed, 27 May 2015 15:11:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34712/#review85376
-----------------------------------------------------------



ambari-agent/src/main/python/ambari_agent/alerts/script_alert.py
<https://reviews.apache.org/r/34712/#comment136919>

    Why is this logger only set if there's a match for the scripts basedir; shouldn't the
initialization of the ScriptAlert class do this in general?



ambari-agent/src/main/python/ambari_agent/alerts/script_alert.py
<https://reviews.apache.org/r/34712/#comment136917>

    Remove print statement


- Jonathan Hurley


On May 27, 2015, 11:09 a.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34712/
> -----------------------------------------------------------
> 
> (Updated May 27, 2015, 11:09 a.m.)
> 
> 
> Review request for Ambari and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-11349
>     https://issues.apache.org/jira/browse/AMBARI-11349
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> See attached files. This came from a devdeploy test where some service check
> was failing due to lack of disk space (BUG - 37173). ambari-agent.out was not
> the reason but was the largest contributor.
> 
> Can you check if we can avoid logging to the out file unless there was an
> error due to which this is expected?
> 
> If out file does not roll this could be an issue in the long run.
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/alerts/script_alert.py 969a01f 
> 
> Diff: https://reviews.apache.org/r/34712/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message