ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jaimin Jetly" <jai...@hortonworks.com>
Subject Re: Review Request 34627: Create/Edit widget: Wizard doesn't navigate to the current wizard page when another window is open
Date Tue, 26 May 2015 21:11:10 GMT


> On May 24, 2015, 2:09 p.m., Yusaku Sako wrote:
> > ambari-web/app/router.js, line 374
> > <https://reviews.apache.org/r/34627/diff/1/?file=970855#file970855line374>
> >
> >     A minor nit, but this is getting a little ugly.
> >     Perhaps we can simplify this by checking for clusterStatusOnServer once at the
top and then doing switch on clusterStatusOnServer.wizardControllerName, case on App.router.get('widgetWizardController.name'),
or maybe even better would be to create an object with the mapping and make the routing generic.
 Like
> >     {
> >       ...,
> >       'rMHighAvailabilityWizardController': 'main.services.enableRMHighAvailability',

> >       'rollbackHighAvailabilityWizardController': 'main.services.rollbackHighAvailability',

> >       ...
> >     }
> >     and route based on this.
> >     Maybe create another JIRA to take care of this in the future.

The suggestion has been incorporated in the new patch


- Jaimin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34627/#review85092
-----------------------------------------------------------


On May 26, 2015, 9:10 p.m., Jaimin Jetly wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34627/
> -----------------------------------------------------------
> 
> (Updated May 26, 2015, 9:10 p.m.)
> 
> 
> Review request for Ambari, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-11359
>     https://issues.apache.org/jira/browse/AMBARI-11359
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> STR:
> Navigate through the Create Widget Wizard.
> Once it reach metrics and expression page close the browser window
> Open another browser window
> Expected behavior: This should directly navigate to metrics and expression page
> Actual behavior: opening another browser navigates to dashboard page. When create/edit
widget is launched then it navigated to the metrics and expression page
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/controllers/main/service/widgets/create/wizard_controller.js 532ee7a

>   ambari-web/app/data/controller_route.js PRE-CREATION 
>   ambari-web/app/router.js 46e62aa 
> 
> Diff: https://reviews.apache.org/r/34627/diff/
> 
> 
> Testing
> -------
> 
> Tested the patch to work on live cluster
> verified that all unit tests passes successfully
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message