ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tom Beerbower" <tbeerbo...@hortonworks.com>
Subject Re: Review Request 34657: Views : expose extra classpath setting
Date Tue, 26 May 2015 16:03:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34657/
-----------------------------------------------------------

(Updated May 26, 2015, 4:03 p.m.)


Review request for Ambari, Jonathan Hurley and Nate Cole.


Changes
-------

updated diff


Bugs: AMBARI-11208
    https://issues.apache.org/jira/browse/AMBARI-11208


Repository: ambari


Description
-------

Each view should expose a way to set extra classpath info for a view.

    <view>
      <name>HELLO_WORLD</name>
      <label>The Hello World View!</label>
      <version>1.0.0</version>
      <classpath>
        <path>/usr/lib/ambari-server/foo.jar</path>
        <path>/home/hdfs/</path>
       </classpath>
       <instance>
         <name>INSTANCE_1</name>
       </instance>
    </view>


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/view/ViewClassLoader.java b7cb594 
  ambari-server/src/main/java/org/apache/ambari/server/view/ViewExtractor.java 43efc7d 
  ambari-server/src/main/java/org/apache/ambari/server/view/configuration/ViewConfig.java
6164bb7 
  ambari-server/src/test/java/org/apache/ambari/server/view/ViewClassLoaderTest.java 8e22c49

  ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java a0ee6b3

  ambari-server/src/test/java/org/apache/ambari/server/view/configuration/ViewConfigTest.java
beb8bde 
  ambari-views/src/main/resources/view.xsd 37737c1 

Diff: https://reviews.apache.org/r/34657/diff/


Testing
-------

Manual tested.

Added new unit tests.

mvn clean test

All tests pass.


Thanks,

Tom Beerbower


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message