ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Hurley" <jhur...@hortonworks.com>
Subject Re: Review Request 34653: Namenode HA monitoring broken on cluster secured with HTTP SPNEGO (2.1)
Date Tue, 26 May 2015 15:37:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34653/#review85181
-----------------------------------------------------------



ambari-agent/src/main/python/ambari_agent/alerts/metric_alert.py
<https://reviews.apache.org/r/34653/#comment136694>

    Why not use "BaseAlert.RESULT_SKIPPED" here?



ambari-agent/src/main/python/ambari_agent/alerts/metric_alert.py
<https://reviews.apache.org/r/34653/#comment136696>

    indent?



ambari-agent/src/main/python/ambari_agent/alerts/metric_alert.py
<https://reviews.apache.org/r/34653/#comment136698>

    Double negative; consider revising to `if json_is_valid`


- Jonathan Hurley


On May 25, 2015, 1:30 p.m., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34653/
> -----------------------------------------------------------
> 
> (Updated May 25, 2015, 1:30 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-11372
>     https://issues.apache.org/jira/browse/AMBARI-11372
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Namenode HA monitoring in Ambari is broken when the cluster is secured using HTTP SPNEGO.

> Additionally, Ambari no longer indicates which is the Active Namenode.
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/AlertSchedulerHandler.py 29807e2 
>   ambari-agent/src/main/python/ambari_agent/alerts/metric_alert.py a50b202 
>   ambari-agent/src/main/python/ambari_agent/alerts/web_alert.py 34e25e0 
>   ambari-agent/src/test/python/ambari_agent/TestAlerts.py 6bdb945 
>   ambari-agent/src/test/python/ambari_agent/TestMetricAlert.py e3fe32a 
>   ambari-common/src/main/python/resource_management/libraries/functions/__init__.py ae6e47b

>   ambari-common/src/main/python/resource_management/libraries/functions/curl_krb_request.py
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog210.java
bdfbb1a 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/alerts.json cd7f31e

>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/alerts/alert_checkpoint_time.py
b44c2d4 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/alerts/alert_ha_namenode_health.py
0d0e473 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/alerts.json db6d73d

>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/alerts/alert_nodemanager_health.py
1cdeb97 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/alerts/alert_nodemanagers_summary.py
eafdbd0 
> 
> Diff: https://reviews.apache.org/r/34653/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message