ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tom Beerbower" <tbeerbo...@hortonworks.com>
Subject Re: Review Request 34657: Views : expose extra classpath setting
Date Tue, 26 May 2015 15:34:26 GMT


> On May 26, 2015, 2:58 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/view/configuration/ViewConfig.java,
lines 252-267
> > <https://reviews.apache.org/r/34657/diff/1/?file=971506#file971506line252>
> >
> >     Nit: can use StringUtils.join here to make your life easier :)

Thanks for the review.  That makes it nice and clean.  I'll update.


- Tom


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34657/#review85174
-----------------------------------------------------------


On May 25, 2015, 8:43 p.m., Tom Beerbower wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34657/
> -----------------------------------------------------------
> 
> (Updated May 25, 2015, 8:43 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-11208
>     https://issues.apache.org/jira/browse/AMBARI-11208
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Each view should expose a way to set extra classpath info for a view.
> 
>     <view>
>       <name>HELLO_WORLD</name>
>       <label>The Hello World View!</label>
>       <version>1.0.0</version>
>       <classpath>
>         <path>/usr/lib/ambari-server/foo.jar</path>
>         <path>/home/hdfs/</path>
>        </classpath>
>        <instance>
>          <name>INSTANCE_1</name>
>        </instance>
>     </view>
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/view/ViewClassLoader.java b7cb594

>   ambari-server/src/main/java/org/apache/ambari/server/view/ViewExtractor.java 43efc7d

>   ambari-server/src/main/java/org/apache/ambari/server/view/configuration/ViewConfig.java
6164bb7 
>   ambari-server/src/test/java/org/apache/ambari/server/view/ViewClassLoaderTest.java
8e22c49 
>   ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java a0ee6b3

>   ambari-server/src/test/java/org/apache/ambari/server/view/configuration/ViewConfigTest.java
beb8bde 
>   ambari-views/src/main/resources/view.xsd 37737c1 
> 
> Diff: https://reviews.apache.org/r/34657/diff/
> 
> 
> Testing
> -------
> 
> Manual tested.
> 
> Added new unit tests.
> 
> mvn clean test
> 
> All tests pass.
> 
> 
> Thanks,
> 
> Tom Beerbower
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message