-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34657/#review85174
-----------------------------------------------------------
Ship it!
ambari-server/src/main/java/org/apache/ambari/server/view/configuration/ViewConfig.java
<https://reviews.apache.org/r/34657/#comment136685>
Nit: can use StringUtils.join here to make your life easier :)
- Nate Cole
On May 25, 2015, 4:43 p.m., Tom Beerbower wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34657/
> -----------------------------------------------------------
>
> (Updated May 25, 2015, 4:43 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-11208
> https://issues.apache.org/jira/browse/AMBARI-11208
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Each view should expose a way to set extra classpath info for a view.
>
> <view>
> <name>HELLO_WORLD</name>
> <label>The Hello World View!</label>
> <version>1.0.0</version>
> <classpath>
> <path>/usr/lib/ambari-server/foo.jar</path>
> <path>/home/hdfs/</path>
> </classpath>
> <instance>
> <name>INSTANCE_1</name>
> </instance>
> </view>
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewClassLoader.java b7cb594
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewExtractor.java 43efc7d
> ambari-server/src/main/java/org/apache/ambari/server/view/configuration/ViewConfig.java
6164bb7
> ambari-server/src/test/java/org/apache/ambari/server/view/ViewClassLoaderTest.java
8e22c49
> ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java a0ee6b3
> ambari-server/src/test/java/org/apache/ambari/server/view/configuration/ViewConfigTest.java
beb8bde
> ambari-views/src/main/resources/view.xsd 37737c1
>
> Diff: https://reviews.apache.org/r/34657/diff/
>
>
> Testing
> -------
>
> Manual tested.
>
> Added new unit tests.
>
> mvn clean test
>
> All tests pass.
>
>
> Thanks,
>
> Tom Beerbower
>
>
|