ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu" <yuzhih...@gmail.com>
Subject Review Request 34605: Value of hbase.tmp.dir should contain ${user.name} instead of hard coded directory path
Date Fri, 22 May 2015 18:44:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34605/
-----------------------------------------------------------

Review request for Ambari.


Bugs: AMBARI-11312
    https://issues.apache.org/jira/browse/AMBARI-11312


Repository: ambari


Description
-------

Currently hbase.tmp.dir is hard coded with /hadoop/hbase .
We saw the following error when testing Phoenix UDF functionality:

15/05/17 14:56:11 WARN util.DynamicClassLoader: Failed to load new jar UDF_artifact-1.0-SNAPSHOT.jar
java.io.FileNotFoundException: /grid/0/var/log/hbase/local/jars/UDF_artifact-1.0-SNAPSHOT.jar
(Permission denied)
	at java.io.FileOutputStream.open(Native Method)
	at java.io.FileOutputStream.<init>(FileOutputStream.java:221)
	at org.apache.hadoop.fs.RawLocalFileSystem$LocalFSFileOutputStream.<init>(RawLocalFileSystem.java:222)
	at org.apache.hadoop.fs.RawLocalFileSystem$LocalFSFileOutputStream.<init>(RawLocalFileSystem.java:209)
	at org.apache.hadoop.fs.RawLocalFileSystem.createOutputStreamWithMode(RawLocalFileSystem.java:305)
	at org.apache.hadoop.fs.RawLocalFileSystem.create(RawLocalFileSystem.java:293)
	at org.apache.hadoop.fs.RawLocalFileSystem.create(RawLocalFileSystem.java:326)

Value of hbase.tmp.dir should contain ${user.name} instead of hard coded directory path


Diffs
-----

  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/configuration/hbase-site.xml
59fa842 
  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
1f62ee7 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/scripts/params.py e0934ec

  ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/params.py
b205f39 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py c6d632d

  ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_client.py 5b57393 
  ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py cc404eb 
  ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_regionserver.py 3175a01 
  ambari-server/src/test/python/stacks/2.0.6/HBASE/test_phoenix_queryserver.py 5f1d856 
  ambari-server/src/test/python/stacks/2.0.6/hooks/before-ANY/test_before_any.py 5c8154e 

Diff: https://reviews.apache.org/r/34605/diff/


Testing
-------

Tested patch on VM: hbase daemons started fine. ${user.name} is kept in hbase-site.xml


Thanks,

Ted Yu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message