ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tom Beerbower" <tbeerbo...@hortonworks.com>
Subject Re: Review Request 34555: Views: URLStreamProvider.readFrom requires body, no way to do GET request
Date Thu, 21 May 2015 19:05:56 GMT


> On May 21, 2015, 6:23 p.m., Alejandro Fernandez wrote:
> > Ship It!

Thanks for the review!


- Tom


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34555/#review84750
-----------------------------------------------------------


On May 21, 2015, 5:59 p.m., Tom Beerbower wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34555/
> -----------------------------------------------------------
> 
> (Updated May 21, 2015, 5:59 p.m.)
> 
> 
> Review request for Ambari and Nate Cole.
> 
> 
> Bugs: AMBARI-11310
>     https://issues.apache.org/jira/browse/AMBARI-11310
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Currently readFrom method from ViewURLStreamProvider contains code
> 
>     return getInputStream(spec, requestMethod, headers, body.getBytes());
> 
> hence, no way to pass null body.
> 
> Sending even empty body marks all GET requests as POST.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/view/ViewAmbariStreamProvider.java
d36f562 
>   ambari-server/src/main/java/org/apache/ambari/server/view/ViewURLStreamProvider.java
32c130d 
>   ambari-server/src/test/java/org/apache/ambari/server/view/ViewAmbariStreamProviderTest.java
d424a29 
>   ambari-server/src/test/java/org/apache/ambari/server/view/ViewURLStreamProviderTest.java
908e63c 
> 
> Diff: https://reviews.apache.org/r/34555/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Tom Beerbower
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message