ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Nettleton" <rnettle...@hortonworks.com>
Subject Review Request 34550: Adds handling for Oozie HA property for Blueprint exports
Date Thu, 21 May 2015 16:41:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34550/
-----------------------------------------------------------

Review request for Ambari, John Speidel, Mahadev Konar, and Robert Levas.


Bugs: AMBARI-11308
    https://issues.apache.org/jira/browse/AMBARI-11308


Repository: ambari


Description
-------

This patch addresses AMBARI-11308.  

An "oozie-site" property, "oozie.zookeeper.connection.string", shows hostname information
when a Blueprint is exported from a running cluster. 

This patch addresses this issue by:

1. Registering a new property updater for this property.  Since this property is optional,
and only used in HA scenarions, this property is not defined in the stacks.  The BlueprintConfigurationProcessor
handles this case dynamically when clusters are updated with configuration, or when a Blueprint
is being exported from a running cluster. 
2. Sets the "OOZIE_SERVER" cardinality to "1+" in the latest common_services definition. 
Recent refactorings of the Oozie stack definitions changed the inheritance hierarchy, which
caused HDP 2.3 Oozie HA Blueprint deployments to fail validation.  This small change updates
the metadata for the Oozie server to include more than one instance in a cluster. 
3. Adds a new unit test to verify this change.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
6984881 
  ambari-server/src/main/resources/common-services/OOZIE/5.0.0.2.3/metainfo.xml 463abc3 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
6849b45 

Diff: https://reviews.apache.org/r/34550/diff/


Testing
-------

1. Deployed a 3-node Oozie HA cluster.  Exported a Blueprint from the running cluster, and
verified that no hostname information is included in the Blueprint. 
2. Deployed a 1-node Oozie cluster using the Ambari UI, to further verify that my small stack
metadata change does not break Oozie cluster deployments. 
3. Ran the ambari-server unit test suite, which is passing.


Thanks,

Robert Nettleton


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message