ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Florian Barca" <fba...@hortonworks.com>
Subject Re: Review Request 34352: Make Kafka Metrics Reporter agnostic to the metrics names size
Date Mon, 18 May 2015 14:36:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34352/#review84149
-----------------------------------------------------------

Ship it!


Ship It!

- Florian Barca


On May 18, 2015, 1:59 p.m., Emil Anca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34352/
> -----------------------------------------------------------
> 
> (Updated May 18, 2015, 1:59 p.m.)
> 
> 
> Review request for Ambari, Costel Radulescu, Florian Barca, and Sid Wagle.
> 
> 
> Bugs: AMBARI-11211
>     https://issues.apache.org/jira/browse/AMBARI-11211
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Problem: Processing histograms and timers has hardcoded number of expected metric names
> Solution: Replaced with array union via apache-commons
> 
> 
> Diffs
> -----
> 
>   ambari-metrics/ambari-metrics-kafka-sink/pom.xml a4361b0 
>   ambari-metrics/ambari-metrics-kafka-sink/src/main/java/org/apache/hadoop/metrics2/sink/kafka/KafkaTimelineMetricsReporter.java
00a58ee 
> 
> Diff: https://reviews.apache.org/r/34352/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Emil Anca
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message