ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Onischuk" <aonis...@hortonworks.com>
Subject Review Request 34355: Duplicate repo_suse_rhel.j2 templates
Date Mon, 18 May 2015 14:15:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34355/
-----------------------------------------------------------

Review request for Ambari and Vitalyi Brodetskyi.


Bugs: AMBARI-11214
    https://issues.apache.org/jira/browse/AMBARI-11214


Repository: ambari


Description
-------

We have two templates to create .repo files. Which one is used when (in cases
where users need to set enabled=0)? Can we eliminate one of them? Will need to
update docs for satellite setup based on this situation.

<https://github.com/apache/ambari/blob/trunk/ambari-
server/src/main/resources/custom_actions/templates/repo_suse_rhel.j2>  
<https://github.com/apache/ambari/blob/trunk/ambari-
server/src/main/resources/stacks/HDP/2.0.6/hooks/before-
INSTALL/templates/repo_suse_rhel.j2>


Diffs
-----

  ambari-agent/src/test/python/resource_management/TestRepositoryResource.py c31cc20 
  ambari-common/src/main/python/resource_management/libraries/data/repo_suse_rhel.j2 PRE-CREATION

  ambari-common/src/main/python/resource_management/libraries/data/repo_ubuntu.j2 PRE-CREATION

  ambari-common/src/main/python/resource_management/libraries/providers/repository.py 85ad83e

  ambari-server/src/main/resources/custom_actions/templates/repo_suse_rhel.j2 1cb687f 
  ambari-server/src/main/resources/custom_actions/templates/repo_ubuntu.j2 52d4c9a 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/templates/repo_suse_rhel.j2
d486f89 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/templates/repo_ubuntu.j2
52d4c9a 

Diff: https://reviews.apache.org/r/34355/diff/


Testing
-------

mvn clean test


Thanks,

Andrew Onischuk


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message