ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Levas" <rle...@hortonworks.com>
Subject Re: Review Request 34347: Kerberos: service page incorrect with manual
Date Mon, 18 May 2015 12:42:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34347/
-----------------------------------------------------------

(Updated May 18, 2015, 8:42 a.m.)


Review request for Ambari, Aleksandr Kovalenko, Andrii Tkach, Jaimin Jetly, and Yusaku Sako.


Bugs: AMBARI-11144
    https://issues.apache.org/jira/browse/AMBARI-11144


Repository: ambari


Description
-------

After enabling kerb manual, the configs tab under Kerberos is incorrect.

1) the type should indicate the accurate type (existing MIT, ad or manual), just like the
wizard
2) the kadmin host is showing red but this is manual and it's not required
3) the domains field should be hidden


Diffs
-----

  ambari-web/app/controllers/main/admin/kerberos.js 702d585 
  ambari-web/app/controllers/main/admin/kerberos/step2_controller.js 947ea12 
  ambari-web/app/controllers/main/admin/kerberos/wizard_controller.js 738af3f 
  ambari-web/app/controllers/main/service/info/configs.js abd7048 

Diff: https://reviews.apache.org/r/34347/diff/


Testing (updated)
-------

Manual testing to view changes.

#Local unit tests:
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 57.245s
[INFO] Finished at: Mon May 18 08:36:41 EDT 2015
[INFO] Final Memory: 13M/499M
[INFO] ------------------------------------------------------------------------


Thanks,

Robert Levas


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message