ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alejandro Fernandez" <afernan...@hortonworks.com>
Subject Re: Review Request 34246: Upgrade Is Allowed When A Service Is Installed After Distribute Repositories
Date Sat, 16 May 2015 01:00:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34246/
-----------------------------------------------------------

(Updated May 16, 2015, 1 a.m.)


Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, and Nate Cole.


Changes
-------

Addressed issues


Bugs: AMBARI-11146
    https://issues.apache.org/jira/browse/AMBARI-11146


Repository: ambari


Description
-------

was done before the service was added.

STR:
* Install base services like HDFS and YARN
* Distribute new repository
* Install HBase
* Attempt upgrade

At this point two things should happen:
The web client should not allow the upgrade to happen
The pre-upgrade check HostsRepositoryVersionCheck should prevent the upgrade.


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListener.java
8c8f978 
  ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListenerTest.java
aa8b860 
  ambari-server/src/test/java/org/apache/ambari/server/utils/EventBusSynchronizer.java 4b0c031


Diff: https://reviews.apache.org/r/34246/diff/


Testing
-------

mvn clean test

Reproduced the issue on a local cluster, and verified that the fix worked by Installing a
new version, then adding a service, which marked the host_version and single cluster_version
record as OUT_OF_SYNC.


Thanks,

Alejandro Fernandez


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message