ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Levas" <rle...@hortonworks.com>
Subject Review Request 34224: Add host kerberos client install does not have command text
Date Thu, 14 May 2015 18:07:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34224/
-----------------------------------------------------------

Review request for Ambari, Aleksandr Kovalenko, Andrii Tkach, Jaimin Jetly, and Yusaku Sako.


Bugs: AMBARI-11136
    https://issues.apache.org/jira/browse/AMBARI-11136


Repository: ambari


Description
-------

Add host kerberos client install does not have command text

This issue appears to be a front end issue.  Here is the culprit: 

#app/templates/wizard/step9/step9HostTasksLogPopup.hbs:47
```
{{taskInfo.role}} {{taskInfo.command}}
```

Rather then attempting to use the task's _command_detail_ value, the front end only displays
the task's _role_ and _command_ values which are constrained by the code to be a certain set
of values. The _command_detail_ field does not have that constraint.  

For the offending items in the relevant view,  the following values are set:
```
role: KERBEROS_CLIENT (translated somewhere to "Kerberos Client")
command: CUSTOM_COMMAND (translated somewhere to "custom command")
command_details: SET_KEYTAB KERBEROS/KERBEROS_CLIENT
```

On this note there are several items in that same display (for the Ambari server host) that
read "Ambari Server Action execute". This is the same issue.


Diffs
-----

  ambari-web/app/templates/wizard/step9/step9HostTasksLogPopup.hbs daa082e 
  ambari-web/app/utils/ajax/ajax.js 8998158 
  ambari-web/app/views/wizard/step9/hostLogPopupBody_view.js c81230d 
  ambari-web/test/views/wizard/step9/hostLogPopupBody_view_test.js 530727c 

Diff: https://reviews.apache.org/r/34224/diff/


Testing
-------

Manual testing to view changes

#Local test results:#
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 41.508s
[INFO] Finished at: Thu May 14 14:07:04 EDT 2015
[INFO] Final Memory: 10M/491M
[INFO] ------------------------------------------------------------------------

#Jenkins test results: PENDING#


Thanks,

Robert Levas


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message