ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Speidel" <jspei...@hortonworks.com>
Subject Re: Review Request 34214: Blueprint provisioned clusters don't have service states updated
Date Thu, 14 May 2015 14:53:16 GMT


> On May 14, 2015, 2:48 p.m., Robert Nettleton wrote:
> > ambari-server/src/test/java/org/apache/ambari/server/topology/AmbariContextTest.java,
line 135
> > <https://reviews.apache.org/r/34214/diff/1/?file=959340#file959340line135>
> >
> >     Minor issue:
> >     
> >     You might want to consider using an instance of the EasyMockSupport class to
create all the mocks in this test case.  This would allow the test to take advantage of calls
like:
> >     
> >     mockSupport.replayAll();
> >     mockSupport.verifyAll(); 
> >     
> >     This turns to be a nice addition to EasyMock, since future changes to the test
don't involve manually updating the list of mocks to verify/reply/etc.

Thanks for the suggestion Bob, I agree.  I had thought about it but haven't used EasyMockSupport
in a long time so I just went with what I knew better.  Would it be acceptable to add a comment
to the test case and to switch over when I update with addtional tests in the near future?


- John


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34214/#review83771
-----------------------------------------------------------


On May 14, 2015, 2:28 p.m., John Speidel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34214/
> -----------------------------------------------------------
> 
> (Updated May 14, 2015, 2:28 p.m.)
> 
> 
> Review request for Ambari, Robert Nettleton and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-11134
>     https://issues.apache.org/jira/browse/AMBARI-11134
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Clusters that are provisioned via the REST API don't have service states updated. This
doesn't affect the cluster starting and being operational but in cases where a component doesn't
start, it isn't possible to start the component in the UI by starting the service. Starting
the individual host component will work successfully.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java e6c43ef

>   ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java
e6c2f1e 
>   ambari-server/src/test/java/org/apache/ambari/server/topology/AmbariContextTest.java
PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/topology/TopologyManagerTest.java
df87aec 
> 
> Diff: https://reviews.apache.org/r/34214/diff/
> 
> 
> Testing
> -------
> 
> Functional Testing:
> - Various blueprint install and scaling operations
> 
> Unit Testing:
> - New unit test and all existing java tests pass
> - Several known and unrelated python tests fail which are also failing on the trunk build
> 
> Results :
> 
> Tests run: 2982, Failures: 0, Errors: 0, Skipped: 20
> ...
> ----------------------------------------------------------------------
> Failed tests:
> ERROR: test_pre_rolling_restart (test_knox_gateway.TestKnoxGateway)
> ERROR: test_pre_rolling_restart_23 (test_knox_gateway.TestKnoxGateway)
> ----------------------------------------------------------------------
> Total run:740
> Total errors:2
> Total failures:0
> 
> 
> Thanks,
> 
> John Speidel
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message