ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dmytro Sen" <d...@hortonworks.com>
Subject Re: Review Request 33986: Queue-specific metrics cannot be queried as time series data via Ambari API
Date Tue, 12 May 2015 20:30:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33986/
-----------------------------------------------------------

(Updated Май 12, 2015, 8:30 п.п.)


Review request for Ambari, Jonathan Hurley, Myroslav Papirkovskyy, and Sid Wagle.


Bugs: AMBARI-11030
    https://issues.apache.org/jira/browse/AMBARI-11030


Repository: ambari


Description
-------

Queue-specific metrics cannot be retrieved as time-series data via Ambari API.
/api/v1/clusters/c1/services/YARN/components/RESOURCEMANAGER?fields=metrics/yarn/Queue/root/default/AppsRunning
returns the point-in-time metric properly.
However, when you query for it as time-series, in the following format the API returns nothing:
/api/v1/clusters/c1/services/YARN/components/RESOURCEMANAGER?fields=metrics/yarn/Queue/root/default/AppsRunning[start,end,interval]
The time-series query works if you replace /root/default with /root.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BaseProvider.java
a95342a 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BaseProviderTest.java
380142e 
  ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProviderTest.java
1573708 

Diff: https://reviews.apache.org/r/33986/diff/


Testing (updated)
-------

Manual tests passed.
Unit tests passed


File Attachments
----------------

Can't update diff. Attached updated patch with fix for AMSPropoertyProviderTest
  https://reviews.apache.org/media/uploaded/files/2015/05/12/1a0f6fec-df59-4408-91fa-03678d54f687__AMBARI-11030_2.patch


Thanks,

Dmytro Sen


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message