ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jaimin Jetly" <jai...@hortonworks.com>
Subject Re: Review Request 33906: AMBARI-10752 Update Accumulo config defaults and ambari-web site properties
Date Thu, 07 May 2015 21:10:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33906/#review82910
-----------------------------------------------------------

Ship it!


Ship It!

- Jaimin Jetly


On May 6, 2015, 11:28 p.m., Billie Rinaldi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33906/
> -----------------------------------------------------------
> 
> (Updated May 6, 2015, 11:28 p.m.)
> 
> 
> Review request for Ambari and Jaimin Jetly.
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> This patch resolves several issues we’ve been seeing in tests, mostly by tweaking the
default config values and also adjusting how some of the config files are created.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/utils/StageUtils.java 68a45ec

>   ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/configuration/accumulo-env.xml
dfec771 
>   ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/configuration/accumulo-site.xml
8e6406c 
>   ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/metainfo.xml
7a6004c 
>   ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/files/gc
63fb8bb 
>   ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/files/masters
63fb8bb 
>   ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/files/monitor
63fb8bb 
>   ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/files/slaves
63fb8bb 
>   ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/files/tracers
63fb8bb 
>   ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_configuration.py
4652cc1 
>   ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_service.py
13411e6 
>   ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/params.py
4fc9bed 
>   ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/templates/gc.j2
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/templates/masters.j2
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/templates/monitor.j2
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/templates/slaves.j2
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/templates/tracers.j2
PRE-CREATION 
>   ambari-server/src/main/resources/role_command_order.json 650e2e7 
>   ambari-server/src/main/resources/stacks/HDP/2.2/role_command_order.json 2e2aef6 
>   ambari-web/app/controllers/wizard/step8_controller.js bdfa292 
>   ambari-web/app/data/HDP2/site_properties.js ae6051f 
>   ambari-web/app/models/stack_service.js 1a940e8 
> 
> Diff: https://reviews.apache.org/r/33906/diff/
> 
> 
> Testing
> -------
> 
> I have tested the patch locally on VMs and verified that the configuration files are
created correctly and the configs appear in the UI as expected.
> 
> Also ran "mvn clean test" successfully.
> 
> 
> Thanks,
> 
> Billie Rinaldi
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message