ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yusaku Sako" <yus...@hortonworks.com>
Subject Re: Review Request 33907: Kerberos: "Attention: Some configurations need your attention" msg in Enable Kerb Wizard hides fields
Date Thu, 07 May 2015 19:14:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33907/#review82879
-----------------------------------------------------------

Ship it!


Ship It!

- Yusaku Sako


On May 6, 2015, 7:50 p.m., Robert Levas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33907/
> -----------------------------------------------------------
> 
> (Updated May 6, 2015, 7:50 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko and Yusaku Sako.
> 
> 
> Bugs: AMBARI-10973
>     https://issues.apache.org/jira/browse/AMBARI-10973
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> In the *Enable Kerberos Wizard*'s *Configure Kerberos* step when there are configurations
that require attention the 'Attention: Some configurations need your attention before you
can proceed.
> +Show me properties with issues+' alert shows up.
> 
> When users click +Show me properties with issues+, and resolve their problems the alert
disappears.  The issue is that there is no way to see all of the non-required properties without
purposefully messing up one of the required ones so the alert comes back with the "+Show all
properties+" link in it.
> 
> What should happen is as follows:
> 1. If there are properties that require attention, a yellow attention div is presented
with "Attention: Some configurations need your attention before you can proceed.
> +Show me properties with issues+"
> 2. The user clicks on that link and start addressing the required configurations.
> 3. When all of the configurations have been filled out that div is replaced with a green
div with "All configurations have been addressed. +Show all properties+"
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/controllers/wizard/step7_controller.js e019e1d 
>   ambari-web/app/messages.js 5d85b19 
>   ambari-web/app/templates/common/configs/services_config.hbs 328a954 
>   ambari-web/test/controllers/wizard/step7_test.js 347a859 
> 
> Diff: https://reviews.apache.org/r/33907/diff/
> 
> 
> Testing
> -------
> 
> Manually tested.
> 
> 
> Thanks,
> 
> Robert Levas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message