ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tom Beerbower" <tbeerbo...@hortonworks.com>
Subject Re: Review Request 33914: HDP-2.2 To HDP-2.3 Upgrade Pre-Upgrade Checks
Date Wed, 06 May 2015 21:37:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33914/#review82737
-----------------------------------------------------------

Ship it!


Just a couple minor comments ...


ambari-server/src/main/java/org/apache/ambari/server/checks/HiveDynamicServiceDiscoveryCheck.java
<https://reviews.apache.org/r/33914/#comment133549>

    Doesn't look like services is used.



ambari-server/src/main/java/org/apache/ambari/server/checks/HiveDynamicServiceDiscoveryCheck.java
<https://reviews.apache.org/r/33914/#comment133551>

    Doesn't look like zookeeperQuorum is used.


- Tom Beerbower


On May 6, 2015, 9:34 p.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33914/
> -----------------------------------------------------------
> 
> (Updated May 6, 2015, 9:34 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Nate Cole, and Tom Beerbower.
> 
> 
> Bugs: AMBARI-10976
>     https://issues.apache.org/jira/browse/AMBARI-10976
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Added the upgrade checks for HDP 2.2 to 2.3, including some that were missed for 2.2
to 2.2+. 
> 
> Added an annotation mechanism to define order in which checks are grouped and run.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java
1816ce8 
>   ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java b00d6fb

>   ambari-server/src/main/java/org/apache/ambari/server/checks/ClientRetryPropertyCheck.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/checks/ConfigurationMergeCheck.java
e4dd0e6 
>   ambari-server/src/main/java/org/apache/ambari/server/checks/HiveDynamicServiceDiscoveryCheck.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/checks/HostsHeartbeatCheck.java
cf9e4ae 
>   ambari-server/src/main/java/org/apache/ambari/server/checks/HostsMasterMaintenanceCheck.java
2c5ff28 
>   ambari-server/src/main/java/org/apache/ambari/server/checks/HostsRepositoryVersionCheck.java
0ea5d08 
>   ambari-server/src/main/java/org/apache/ambari/server/checks/SecondaryNamenodeDeletedCheck.java
14ec2c1 
>   ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesDecommissionCheck.java
7497c2f 
>   ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesMaintenanceModeCheck.java
0ae5c46 
>   ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesMapReduceDistributedCacheCheck.java
36526e3 
>   ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesNamenodeHighAvailabilityCheck.java
e43e4fb 
>   ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesTezDistributedCacheCheck.java
41735b4 
>   ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesUpCheck.java e0696fa

>   ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesYarnWorkPreservingCheck.java
a56f35d 
>   ambari-server/src/main/java/org/apache/ambari/server/checks/UpgradeCheck.java PRE-CREATION

>   ambari-server/src/main/java/org/apache/ambari/server/checks/UpgradeCheckGroup.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/checks/UpgradeCheckRegistry.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/checks/YarnRMHighAvailabilityCheck.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/checks/YarnTimelineServerStatePreservingCheck.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
3994a7b 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/PreUpgradeCheckResourceProvider.java
3460423 
>   ambari-server/src/main/java/org/apache/ambari/server/state/CheckHelper.java abaf8e7

>   ambari-server/src/test/java/org/apache/ambari/server/checks/ClientRetryPropertyCheckTest.java
PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/checks/UpgradeCheckOrderTest.java
PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/checks/YarnTimelineServerStatePreservingCheckTest.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/33914/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message