ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Onischuk" <aonis...@hortonworks.com>
Subject Re: Review Request 33835: Improve logging and validation of Pig Service Check
Date Wed, 06 May 2015 21:12:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33835/#review82733
-----------------------------------------------------------



ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/service_check.py
<https://reviews.apache.org/r/33835/#comment133539>

    Why would you check if file which created before exists? 
    
    clean_and_create_file_cmd = format("{cleanup_cmd}; hadoop --config {hadoop_conf_dir} dfs
-put /etc/passwd {input_file}
    
    Hadoop calls are big problem now since they take a lot of time on loaded clusters, we
have ticket to reduce them.
    
    Are you sure we need this check?



ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/service_check.py
<https://reviews.apache.org/r/33835/#comment133540>

    This is the default permissions which are for files hdfs, why do we need this?


- Andrew Onischuk


On May 5, 2015, 1:23 a.m., Alejandro Fernandez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33835/
> -----------------------------------------------------------
> 
> (Updated May 5, 2015, 1:23 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-10920
>     https://issues.apache.org/jira/browse/AMBARI-10920
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Pig Service check should log the output of calling pigSmoke.sh
> Further, it should indicate whether the input password file was copied to HDFS and give
the file appropriate permissions (644)
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/service_check.py
9de30ed 
>   ambari-server/src/test/python/stacks/2.0.6/PIG/test_pig_service_check.py df30085 
>   ambari-server/src/test/python/stacks/2.2/PIG/test_pig_service_check.py f930780 
> 
> Diff: https://reviews.apache.org/r/33835/diff/
> 
> 
> Testing
> -------
> 
> ----------------------------------------------------------------------
> Total run:691
> Total errors:0
> Total failures:0
> OK
> 
> Deployed a cluster with HDP 2.2 and Pig Service Check passed.
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message