ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tom Beerbower" <tbeerbo...@hortonworks.com>
Subject Review Request 33851: Prepare oozie war should check for secure.
Date Tue, 05 May 2015 16:15:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33851/
-----------------------------------------------------------

Review request for Ambari, Jonathan Hurley and Nate Cole.


Bugs: AMBARI-10936
    https://issues.apache.org/jira/browse/AMBARI-10936


Repository: ambari


Description
-------

Restarting oozie server re-generates the oozie web app war. This is not a problem unless the
war has been manually generated with the -secure flag (in the case of https).
Ambari should generate the war with the -secure flag as appropriate based on config which
will drive the war creation.
Whether you need prepare-war –secure or not can be directly inferred from the oozie base
url. If the scheme is https then you need –secure else not.


Diffs
-----

  ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py
77b3cdc 
  ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py
c4a62ea 
  ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
4be8a50 
  ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py c706ee7 
  ambari-server/src/test/python/stacks/2.0.6/configs/secured.json 3faf7a1 

Diff: https://reviews.apache.org/r/33851/diff/


Testing
-------

Manual test Oozie service install/start with oozie-site/oozie.base.url http and https.

Update unit tests for secure.

All tests pass.


Thanks,

Tom Beerbower


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message