ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Hurley" <jhur...@hortonworks.com>
Subject Re: Review Request 33817: Agents Changes For Supporting HDP 2.3 conf-select On Upgrade
Date Tue, 05 May 2015 13:06:12 GMT


> On May 4, 2015, 5:57 p.m., Tom Beerbower wrote:
> > ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_client.py,
line 23
> > <https://reviews.apache.org/r/33817/diff/1/?file=949074#file949074line23>
> >
> >     Are we supposed to replace 'import *'?
> >     
> >     Maybe too much change in one patch.
> 
> Nate Cole wrote:
>     Thanks for the review.  We are, but I lost my python IDE settings and couldn't do
it automagically so I punted on making a big change even bigger.

Even Pycharm made a ton of mistakes when I did the ones in my review; only caught them through
unit tests and redeploying clusters over and over. I think that if you're working on 1 or
2 python files and can exercise them really well before checking in, you should convert them.
In cases like this, I think it's OK not to.


- Jonathan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33817/#review82449
-----------------------------------------------------------


On May 4, 2015, 4:30 p.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33817/
> -----------------------------------------------------------
> 
> (Updated May 4, 2015, 4:30 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Tom Beerbower.
> 
> 
> Bugs: AMBARI-10899
>     https://issues.apache.org/jira/browse/AMBARI-10899
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Where we do hdp-select, make an additional call to supported versioned configs using
a new binary in 2.3+ (conf-select).
> 
> Apologies for the big change, it's many files, but changes-per are very small and repetitive.
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py
PRE-CREATION 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_client.py
cf95692 
>   ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server.py
04d14ee 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_client.py
3955b66 
>   ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/upgrade.py
5a8caf8 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py
1963658 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_client.py
fe487ef 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode.py
8ec1fe9 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py
dd439d7 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_client.py
b390483 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py
feb00eb 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server.py
ac32db1 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py
0373a0d 
>   ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/upgrade.py
c031fa6 
>   ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox_gateway.py
27a302f 
>   ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3/package/scripts/mahout_client.py
c262575 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_client.py
d0e6dad 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py
0bf084e 
>   ambari-server/src/main/resources/common-services/PIG/0.12.0.2.0/package/scripts/pig_client.py
5b81b1f 
>   ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/upgrade.py
99b6edc 
>   ambari-server/src/main/resources/common-services/SLIDER/0.60.0.2.2/package/scripts/slider_client.py
b4ecf20 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/job_history_server.py
353a1da 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/package/scripts/spark_client.py
9f9e3dc 
>   ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/sqoop_client.py
dad0514 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/drpc_server.py
60a5988 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py
8e3c6b4 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/nimbus_prod.py
4865774 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/rest_api.py
9ae82aa 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/supervisor.py
cee42d4 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/supervisor_prod.py
833e8b3 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/ui_server.py
0814282 
>   ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/tez_client.py
9746d13 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/application_timeline_server.py
8cb5a39 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/historyserver.py
b531de9 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/mapreduce2_client.py
6e8e0a8 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/nodemanager.py
bd613ed 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py
a5d494f 
>   ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn_client.py
6e99e41 
>   ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper.py
6ea9047 
>   ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_client.py
92264ab 
>   ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5.2.0/package/scripts/zookeeper_server.py
1b81ff1 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_client.py 58c661b 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py 2a89a40 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_regionserver.py 99e6033

>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_datanode.py 8a90ec8 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_hdfs_client.py 492c8bc 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_journalnode.py 8b2694f 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py 78254ae 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_client.py 97dde86 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 60fda00 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_webhcat_server.py b73fb2b 
>   ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_client.py ec1a783 
>   ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py 463e2d3 
>   ambari-server/src/test/python/stacks/2.0.6/PIG/test_pig_client.py cfa5569 
>   ambari-server/src/test/python/stacks/2.0.6/SQOOP/test_sqoop.py 303904a 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py dc7fc11 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_mapreduce2_client.py 4fdc398 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py 44ea312 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_resourcemanager.py 8f2d192 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_yarn_client.py c70d4ca 
>   ambari-server/src/test/python/stacks/2.0.6/ZOOKEEPER/test_zookeeper_client.py 0969bc4

>   ambari-server/src/test/python/stacks/2.0.6/ZOOKEEPER/test_zookeeper_server.py 641930d

>   ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_client.py 5b92039 
>   ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_server.py a7e3753 
>   ambari-server/src/test/python/stacks/2.1/HIVE/test_hive_metastore.py df1ea4e 
>   ambari-server/src/test/python/stacks/2.1/STORM/test_storm_drpc_server.py b4fef75 
>   ambari-server/src/test/python/stacks/2.1/STORM/test_storm_nimbus.py b3f60d9 
>   ambari-server/src/test/python/stacks/2.1/STORM/test_storm_nimbus_prod.py e68274b 
>   ambari-server/src/test/python/stacks/2.1/STORM/test_storm_rest_api_service.py e283c33

>   ambari-server/src/test/python/stacks/2.1/STORM/test_storm_supervisor.py 4c172da 
>   ambari-server/src/test/python/stacks/2.1/STORM/test_storm_supervisor_prod.py 583d1fc

>   ambari-server/src/test/python/stacks/2.1/STORM/test_storm_ui_server.py 49b27fa 
>   ambari-server/src/test/python/stacks/2.1/TEZ/test_tez_client.py 74273a7 
>   ambari-server/src/test/python/stacks/2.1/YARN/test_apptimelineserver.py fed1350 
>   ambari-server/src/test/python/stacks/2.2/KAFKA/test_kafka_broker.py 151335c 
>   ambari-server/src/test/python/stacks/2.2/KNOX/test_knox_gateway.py 82bee2a 
>   ambari-server/src/test/python/stacks/2.2/RANGER/test_ranger_admin.py 6ac0b63 
>   ambari-server/src/test/python/stacks/2.2/RANGER/test_ranger_usersync.py 249ecbd 
>   ambari-server/src/test/python/stacks/2.2/SLIDER/test_slider_client.py 2a03cde 
>   ambari-server/src/test/python/stacks/2.2/SPARK/test_job_history_server.py 6461964 
>   ambari-server/src/test/python/stacks/2.2/SPARK/test_spark_client.py 30235f0 
>   ambari-server/src/test/python/stacks/2.3/MAHOUT/test_mahout_client.py 628ca96 
> 
> Diff: https://reviews.apache.org/r/33817/diff/
> 
> 
> Testing
> -------
> 
> Confirmed on upgrading 2.2 -> 2.3 (not 100%, but "most" services, it was taking all
day).  Python units added:
> 
> ----------------------------------------------------------------------
> Ran 232 tests in 6.878s
> 
> OK
> ----------------------------------------------------------------------
> Total run:734
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Nate Cole
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message