ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alejandro Fernandez" <afernan...@hortonworks.com>
Subject Re: Review Request 33743: Full Delete of Host : Deleting a host in a cluster should delete references to the host in all tables
Date Tue, 05 May 2015 01:41:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33743/
-----------------------------------------------------------

(Updated May 5, 2015, 1:41 a.m.)


Review request for Ambari, Dmitro Lisnichenko, Jaimin Jetly, Jonathan Hurley, Nate Cole, Sumit
Mohanty, and Sid Wagle.


Changes
-------

Addressed Sid's comments.


Bugs: AMBARI-10877
    https://issues.apache.org/jira/browse/AMBARI-10877


Repository: ambari


Description
-------

Delete a host (even if request does not specify a cluster name), should delete all references
to it.


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java
45900e4 
  ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostConfigMappingDAO.java 34d0e3c

  ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java 7d3f4e4

  ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostStateDAO.java f939de3 
  ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostVersionDAO.java de3b8cb

  ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ServiceConfigDAO.java db0817b

  ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostConfigMappingEntity.java
915b05f 
  ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostRoleCommandEntity.java
061f436 
  ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostStateEntity.java 52ae322

  ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 3764dd1

  ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java 9e63ff2

  ambari-server/src/main/java/org/apache/ambari/server/state/host/HostImpl.java 27f4800 
  ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
ffe35af 
  ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostConfigMappingDAOTest.java
0dcc471 
  ambari-server/src/test/java/org/apache/ambari/server/orm/dao/ServiceConfigDAOTest.java 3d93e4d

  ambari-web/app/messages.js 652c415 
  ambari-web/app/templates/main/host/details/doDeleteHostPopup.hbs a149364 

Diff: https://reviews.apache.org/r/33743/diff/


Testing
-------

Deployed a cluster with several hosts, and performed more advanced actions like creating config
groups and overrides to test the deletion.
Local unit tests passed


Thanks,

Alejandro Fernandez


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message