ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alejandro Fernandez" <afernan...@hortonworks.com>
Subject Re: Review Request 33743: Full Delete of Host : Deleting a host in a cluster should delete references to the host in all tables
Date Fri, 01 May 2015 21:57:26 GMT


> On May 1, 2015, 12:49 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostStateEntity.java,
line 36
> > <https://reviews.apache.org/r/33743/diff/1/?file=947015#file947015line36>
> >
> >     TODO's are fine (I actually prefer `!!! TODO: ` as the format), but I don't
think your name needs to be in it :)

Haha, I was too eager to submit a code review for this. I've got a TODO pattern in IntelliJ
for this, https://www.jetbrains.com/idea/help/add-edit-pattern-dialog.html


> On May 1, 2015, 12:49 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostConfigMappingDAO.java,
lines 309-311
> > <https://reviews.apache.org/r/33743/diff/1/?file=947009#file947009line309>
> >
> >     Any reason this can't be a NamedQuery?

Will fix


> On May 1, 2015, 12:49 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostConfigMappingDAO.java,
lines 307-320
> > <https://reviews.apache.org/r/33743/diff/1/?file=947009#file947009line307>
> >
> >     hostConfigMappingByHost is not a thread-safe collection. Concurrent threads
editing it will probably cause a ConcurrentModException

Will convert to ConcurrentHashSet


- Alejandro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33743/#review82244
-----------------------------------------------------------


On May 1, 2015, 1:31 a.m., Alejandro Fernandez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33743/
> -----------------------------------------------------------
> 
> (Updated May 1, 2015, 1:31 a.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, Sumit Mohanty, and Sid
Wagle.
> 
> 
> Bugs: AMBARI-10877
>     https://issues.apache.org/jira/browse/AMBARI-10877
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Delete a host (even if request does not specify a cluster name), should delete all references
to it.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java
45900e4 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostConfigMappingDAO.java
34d0e3c 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java
7d3f4e4 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostStateDAO.java f939de3

>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostVersionDAO.java de3b8cb

>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ServiceConfigDAO.java
8f8e196 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostRoleCommandEntity.java
3919555 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostStateEntity.java
52ae322 
>   ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
3764dd1 
>   ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java
9e63ff2 
>   ambari-server/src/main/java/org/apache/ambari/server/state/host/HostImpl.java 27f4800

>   ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
ffe35af 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostConfigMappingDAOTest.java
0dcc471 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/dao/ServiceConfigDAOTest.java
3d93e4d 
> 
> Diff: https://reviews.apache.org/r/33743/diff/
> 
> 
> Testing
> -------
> 
> Deployed a cluster with several hosts, and performed more advanced actions like creating
config groups and overrides to test the deletion.
> Local unit tests passed
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message