ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nate Cole" <nc...@hortonworks.com>
Subject Re: Review Request 33745: Pre-Upgrade Checks Should Know Which Stack They Are Valid
Date Fri, 01 May 2015 13:13:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33745/#review82245
-----------------------------------------------------------

Ship it!


Ship It!

- Nate Cole


On April 30, 2015, 11:50 p.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33745/
> -----------------------------------------------------------
> 
> (Updated April 30, 2015, 11:50 p.m.)
> 
> 
> Review request for Ambari, Nate Cole and Tom Beerbower.
> 
> 
> Bugs: AMBARI-10874
>     https://issues.apache.org/jira/browse/AMBARI-10874
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> With rolling upgrades now possible within a stack (HDP 2.2.x.x -> HDP 2.2.y.y) and
between stacks (HDP 2.2 -> HDP 2.3), the pre-upgrade checks are not longer valid for all
upgrade scenarios.
> 
> Instead, each upgrade check should be aware of which stack upgrade they are valid for.
On upgrading, Ambari will produce a list of pre-upgrade checks that are valid for the specific
source and target stacks only.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java
0666df7 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/PrereqCheckRequest.java
b7b4858 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/PreUpgradeCheckResourceProvider.java
a6fd61f 
>   ambari-server/src/main/java/org/apache/ambari/server/state/StackId.java 80aed71 
>   ambari-server/src/test/java/org/apache/ambari/server/checks/HostsHeartbeatCheckTest.java
0b77bcb 
>   ambari-server/src/test/java/org/apache/ambari/server/checks/ServicesDecommissionCheckTest.java
151648f 
>   ambari-server/src/test/java/org/apache/ambari/server/checks/ServicesMaintenanceModeCheckTest.java
ff4e36f 
>   ambari-server/src/test/java/org/apache/ambari/server/checks/ServicesUpCheckTest.java
65b8e7f 
>   ambari-server/src/test/java/org/apache/ambari/server/checks/UpgradeCheckStackVersionTest.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/33745/diff/
> 
> 
> Testing
> -------
> 
> New test added to check various upgrade scenarios.
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message