Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 39E6D17D13 for ; Wed, 1 Apr 2015 18:20:59 +0000 (UTC) Received: (qmail 65714 invoked by uid 500); 1 Apr 2015 18:20:52 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 65685 invoked by uid 500); 1 Apr 2015 18:20:52 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 65674 invoked by uid 99); 1 Apr 2015 18:20:52 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Apr 2015 18:20:52 +0000 Date: Wed, 1 Apr 2015 18:20:52 +0000 (UTC) From: "Dmytro Sen (JIRA)" To: dev@ambari.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Created] (AMBARI-10316) Stack-advisor mechanism when recommending configuration-dependencies has incorrect services.json content MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 Dmytro Sen created AMBARI-10316: ----------------------------------- Summary: Stack-advisor mechanism when recommending configuration-dependencies has incorrect services.json content Key: AMBARI-10316 URL: https://issues.apache.org/jira/browse/AMBARI-10316 Project: Ambari Issue Type: Bug Components: ambari-server, stacks Affects Versions: 2.1.0 Reporter: Dmytro Sen Assignee: Dmytro Sen Priority: Critical Fix For: 2.1.0 When the POST call is made for recommending {{configuration-dependencies}}, we generate the services.json file with following extra content: {code} "changed-configurations" : [ { "type" : "yarn-site", "name" : "yarn.scheduler.maximum-allocation-mb" } ], "depended-configurations" : [ { "type" : "mapred-site", "name" : "yarn.app.mapreduce.am.resource.mb" }, { "type" : "yarn-site", "name" : "yarn.scheduler.maximum-allocation-mb" }, { "type" : "mapred-site", "name" : "yarn.app.mapreduce.am.admin-command-opts" }, { "type" : "mapred-site", "name" : "mapreduce.map.memory.mb" }, { "type" : "mapred-site", "name" : "yarn.app.mapreduce.am.command-opts" }, { "type" : "mapred-site", "name" : "mapreduce.reduce.java.opts" }, { "type" : "mapred-site", "name" : "mapreduce.reduce.memory.mb" }, { "type" : "mapred-site", "name" : "mapreduce.task.io.sort.mb" }, { "type" : "mapred-site", "name" : "mapreduce.map.java.opts" } ] {code} The configuration depended-by should not be added on to the services.json like this. All the configuration dependencies should be got from manipulating the {{org.apache.ambari.server.api.services.stackadvisor.commands.StackAdvisorCommand.GET_SERVICES_INFO_URI}} value. Changing the value to include configuration depends_on and depended_by information. Then the python script should build the dependency-chain inside itself instead of doing it in Java and adding to services.json. The reason this is important is that for future functionality, we need services.json and hosts.json to faithfully represent the cluster's services and hosts information. The custom stack-advisor scripts should have logic to interpret it for their own needs. If we do some processing in Java, then stack-providers will not have chance to make their own interpretations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)