Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Content-Type: multipart/alternative;
 boundary="===============8140971473725583233=="
MIME-Version: 1.0
Subject: Re: Review Request 33521: Internal Exception:
 org.postgresql.util.PSQLException: ERROR: column "config_attributes" does
 not exist
From: "Alejandro Fernandez" <afernandez@hortonworks.com>
To: "Robert Nettleton" <rnettleton@hortonworks.com>,
 "John Speidel" <jspeidel@hortonworks.com>,
 "Robert Levas" <rlevas@hortonworks.com>,
 "Alejandro Fernandez" <afernandez@hortonworks.com>,
 "Jonathan Hurley" <jhurley@hortonworks.com>,
 "Costel Radulescu" <cradulescu@hortonworks.com>
Cc: "Emil Anca" <eanca@hortonworks.com>, "Ambari" <dev@ambari.apache.org>
Date: Thu, 30 Apr 2015 19:26:47 -0000
Message-ID: <20150430192647.1508.17971@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Alejandro Fernandez" <noreply@reviews.apache.org>
References: <20150430182213.1509.83187@reviews.apache.org>
In-Reply-To: <20150430182213.1509.83187@reviews.apache.org>
Reply-To: "Alejandro Fernandez" <afernandez@hortonworks.com>

--===============8140971473725583233==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


> On April 30, 2015, 6:22 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog170.java, line 518
> > <https://reviews.apache.org/r/33521/diff/3/?file=946159#file946159line518>
> >
> >     In Ambari-DDL-MySQL-CREATE.sql, the types differ in each of the tables,
> >     
> >     hostgroup_configuration : config_attributes TEXT
> >     blueprint_configuration : config_attributes VARCHAR(32000)
> >     clusterconfig : config_attributes LONGTEXT
> >     
> >     In Ambari-DDL-SQLServer-CREATE.sql, similar issues
> 
> Jonathan Hurley wrote:
>     Ugh. Way to be consistent, right?
>     
>     I think that LONGTEXT needs to be avoided in general for MySQL as it causes performance issues due to how it creates temporary tables on SELECT. TEXT seems pretty safe, but there is no direct mapping between EclipseLink and TEXT as char[] maps to LONGTEXT.

VARCHAR is tried and true


- Alejandro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33521/#review82168
-----------------------------------------------------------


On April 30, 2015, 3:02 p.m., Emil Anca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33521/
> -----------------------------------------------------------
> 
> (Updated April 30, 2015, 3:02 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Costel Radulescu, Jonathan Hurley, John Speidel, Robert Levas, and Robert Nettleton.
> 
> 
> Bugs: AMBARI-10665
>     https://issues.apache.org/jira/browse/AMBARI-10665
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> PROBLEM: Request for blueprints will fail with server error 500 following upgrade from Ambari 1.6.1 to 1.7
> 
> SOLUTION: Added missing columns
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog170.java d6d4567 
>   ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog170Test.java 377c0f7 
> 
> Diff: https://reviews.apache.org/r/33521/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Main ....................................... SUCCESS [6.912s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.116s]
> [INFO] Ambari Web ........................................ SUCCESS [29.655s]
> [INFO] Ambari Views ...................................... SUCCESS [1.196s]
> [INFO] Ambari Admin View ................................. SUCCESS [19.873s]
> [INFO] Ambari Metrics Common ............................. SUCCESS [1.116s]
> [INFO] Ambari Server ..................................... SUCCESS [2:39.489s]
> [INFO] Ambari Agent ...................................... SUCCESS [9.179s]
> [INFO] Ambari Client ..................................... SUCCESS [0.202s]
> [INFO] Ambari Python Client .............................. SUCCESS [1.121s]
> [INFO] Ambari Groovy Client .............................. SUCCESS [2.917s]
> [INFO] Ambari Shell ...................................... SUCCESS [0.108s]
> [INFO] Ambari Python Shell ............................... SUCCESS [0.637s]
> [INFO] Ambari Groovy Shell ............................... SUCCESS [1.760s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Emil Anca
> 
>


--===============8140971473725583233==--