Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id EA96D17F37 for ; Wed, 29 Apr 2015 23:54:44 +0000 (UTC) Received: (qmail 64537 invoked by uid 500); 29 Apr 2015 23:54:44 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 64501 invoked by uid 500); 29 Apr 2015 23:54:44 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 64475 invoked by uid 99); 29 Apr 2015 23:54:44 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 29 Apr 2015 23:54:44 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 246C91DBABA; Wed, 29 Apr 2015 23:54:45 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1402742390500008654==" MIME-Version: 1.0 Subject: Re: Review Request 33698: Initial service definition for Apache Atlas From: "Jonathan Maron" To: "Alejandro Fernandez" , "Jayush Luniya" , "Sid Wagle" , "Sumit Mohanty" Cc: "Jonathan Maron" , "Ambari" Date: Wed, 29 Apr 2015 23:54:45 -0000 Message-ID: <20150429235445.17829.1351@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Jonathan Maron" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/33698/ X-Sender: "Jonathan Maron" References: <20150429220357.26755.7361@reviews.apache.org> In-Reply-To: <20150429220357.26755.7361@reviews.apache.org> Reply-To: "Jonathan Maron" X-ReviewRequest-Repository: ambari --===============1402742390500008654== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On April 29, 2015, 10:03 p.m., Sumit Mohanty wrote: > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/configuration/application-properties.xml, line 21 > > > > > > You have this file. So you can add one more entry for content and use that as template. Is that a necessary change or simply a style change? i.e. is it a blocker? ;) - Jonathan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33698/#review82037 ----------------------------------------------------------- On April 29, 2015, 9:37 p.m., Jonathan Maron wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33698/ > ----------------------------------------------------------- > > (Updated April 29, 2015, 9:37 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Sumit Mohanty, and Sid Wagle. > > > Bugs: https://issues.apache.org/jira/browse/AMBARI-10853 > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/AMBARI-10853 > > > Repository: ambari > > > Description > ------- > > This is the initial commit for a service definition for Apache Atlas. It provides the files necessary to install, configure, and start the Atlas Metadata Server. There will be follow on commits for supporting: > > 1) Security/Kerberos (there is a preliminary kerberos.json file, but it has yet to be leveraged and tested but is in the package for completeness/place holder). > 2) UI enhancements - configuration panels, quick links, metrics (an alerts.json is included for completeness but not tested) > > > Diffs > ----- > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/alerts.json PRE-CREATION > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/configuration/application-properties.xml PRE-CREATION > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/configuration/metadata-env.xml PRE-CREATION > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/kerberos.json PRE-CREATION > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/metainfo.xml PRE-CREATION > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/metadata.py PRE-CREATION > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/metadata_server.py PRE-CREATION > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/params.py PRE-CREATION > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/properties_config.py PRE-CREATION > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/service_check.py PRE-CREATION > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/scripts/status_params.py PRE-CREATION > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/templates/application.properties.j2 PRE-CREATION > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3.0.0/package/templates/log4j.xml.j2 PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.3/role_command_order.json 93be128 > ambari-server/src/main/resources/stacks/HDP/2.3/services/ATLAS/metainfo.xml PRE-CREATION > ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py PRE-CREATION > ambari-server/src/test/python/stacks/2.3/configs/default.json 3073a22 > > Diff: https://reviews.apache.org/r/33698/diff/ > > > Testing > ------- > > Functional testing was performed using an Amabri installation on a local VM-based network. In addition, unit tests for configure, start, and stop have been written. > > > Thanks, > > Jonathan Maron > > --===============1402742390500008654==--