Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Content-Type: multipart/alternative;
 boundary="===============3544099414466068330=="
MIME-Version: 1.0
Subject: Re: Review Request 33489: RU: desired stack must be cascaded during
 upgrade
From: "Nate Cole" <ncole@hortonworks.com>
To: "Alejandro Fernandez" <afernandez@hortonworks.com>,
 "Jonathan Hurley" <jhurley@hortonworks.com>
Cc: "Nate Cole" <ncole@hortonworks.com>, "Ambari" <dev@ambari.apache.org>
Date: Thu, 23 Apr 2015 20:39:42 -0000
Message-ID: <20150423203942.2947.10141@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Nate Cole" <noreply@reviews.apache.org>
References: <20150423202011.2948.52467@reviews.apache.org>
In-Reply-To: <20150423202011.2948.52467@reviews.apache.org>
Reply-To: "Nate Cole" <ncole@hortonworks.com>

--===============3544099414466068330==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


> On April 23, 2015, 4:20 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java, line 898
> > <https://reviews.apache.org/r/33489/diff/1/?file=940545#file940545line898>
> >
> >     Would be nice to have some java doc for this function.

Javadoc is in the interface


> On April 23, 2015, 4:20 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java, line 363
> > <https://reviews.apache.org/r/33489/diff/1/?file=940543#file940543line363>
> >
> >     Why is this needed here? This function is only meant to do checks, not edits.

While that's true, there is no other logical place to set the stack version for non-reporting HostComponents.  Finalize overall does writes, so it didn't seem unreasonable to put it here since upgrades would be the only time that could happen (for non-reporting).


- Nate


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33489/#review81383
-----------------------------------------------------------


On April 23, 2015, 3:56 p.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33489/
> -----------------------------------------------------------
> 
> (Updated April 23, 2015, 3:56 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-10005
>     https://issues.apache.org/jira/browse/AMBARI-10005
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> * Cascade the desired stack id to sub-objects: service, component, host_component
> * New configs should only be added on upgrade, not downgrade (separate jira)
> * Non-reportable components should be handled in Finalize
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 596525b 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java 82b7307 
>   ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java d97ad61 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 64fe765 
>   ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java f62e3f3 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java 5de2eac 
> 
> Diff: https://reviews.apache.org/r/33489/diff/
> 
> 
> Testing
> -------
> 
> Manual 2.2.x -> 2.2.y and 2.2 -> 2.3 + automated:
> 
> Tests run: 2881, Failures: 0, Errors: 0, Skipped: 17
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 24:57.558s
> [INFO] Finished at: Thu Apr 23 15:49:20 EDT 2015
> [INFO] Final Memory: 40M/714M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Nate Cole
> 
>


--===============3544099414466068330==--