Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Content-Type: multipart/alternative;
 boundary="===============4892538629665997572=="
MIME-Version: 1.0
Subject: Re: Review Request 33405: [WinTP2] SQLServer transaction deadlock
 causes deployment on Windows to be busted
From: "Jonathan Hurley" <jhurley@hortonworks.com>
To: "Jayush Luniya" <jluniya@hortonworks.com>,
 "Artem Baranchuk" <abaranchuk@hortonworks.com>,
 "Eugene Chekanskiy" <echekanskiy@hortonworks.com>,
 "Jonathan Hurley" <jhurley@hortonworks.com>,
 "Sid Wagle" <swagle@hortonworks.com>, "Ivan Kozlov" <ikozlov@hortonworks.com>
Cc: "Florian Barca" <fbarca@hortonworks.com>, "Ambari" <dev@ambari.apache.org>
Date: Wed, 22 Apr 2015 18:52:30 -0000
Message-ID: <20150422185230.2948.85159@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Jonathan Hurley" <noreply@reviews.apache.org>
References: <20150422182958.2947.32841@reviews.apache.org>
In-Reply-To: <20150422182958.2947.32841@reviews.apache.org>
Reply-To: "Jonathan Hurley" <jhurley@hortonworks.com>

--===============4892538629665997572==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33405/#review81201
-----------------------------------------------------------


ambari-server/conf/windows/ambari.properties
<https://reviews.apache.org/r/33405/#comment131451>

    I don't think this looks right; you're restricting the main connection pool to 1 connection. 
    
    Also, we should just use sensible defaults in Configuration and now have weirdo values here unless they need to be tuned.


- Jonathan Hurley


On April 22, 2015, 2:29 p.m., Florian Barca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33405/
> -----------------------------------------------------------
> 
> (Updated April 22, 2015, 2:29 p.m.)
> 
> 
> Review request for Ambari, Artem Baranchuk, Eugene Chekanskiy, Ivan Kozlov, Jonathan Hurley, Jayush Luniya, and Sid Wagle.
> 
> 
> Bugs: AMBARI-10637
>     https://issues.apache.org/jira/browse/AMBARI-10637
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Split the Eclipselink sequence connection pool away from the main one.
> 
> 
> Diffs
> -----
> 
>   ambari-server/conf/windows/ambari.properties 58c8d9feb5ae48a58e26c605c78897ee04819dc4 
>   ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java cd2bafd4188ff14bd22952021d32d0e5abc4e4c5 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java a57a1507a13aa9dc500e06d8e1b23459e0342f79 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java 184c8dbaf944517f0ba6643fe1a2d16d244c24db 
>   ambari-server/src/main/resources/META-INF/persistence.xml b864c591796967f7471e65ebbc995f8aabd2bed5 
>   ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java 63447cad745ea04901671ec66c10716ef5c3fe5c 
> 
> Diff: https://reviews.apache.org/r/33405/diff/
> 
> 
> Testing
> -------
> 
> mvn clean install
> 
> deployed in a local VM cluster -> no repro
> 
> 
> Thanks,
> 
> Florian Barca
> 
>


--===============4892538629665997572==--