Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E48961740D for ; Mon, 20 Apr 2015 15:16:39 +0000 (UTC) Received: (qmail 63940 invoked by uid 500); 20 Apr 2015 15:16:39 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 63905 invoked by uid 500); 20 Apr 2015 15:16:39 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 63880 invoked by uid 99); 20 Apr 2015 15:16:39 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 20 Apr 2015 15:16:39 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 2DF7F1CC0BC; Mon, 20 Apr 2015 15:16:41 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0280225378490639978==" MIME-Version: 1.0 Subject: Review Request 33361: HDFS namenode_opt_newsize and namenode_opt_maxnewsize not using number of datanodes in calculation From: "Dmytro Sen" To: "Myroslav Papirkovskyy" , "Srimanth Gunturi" Cc: "Dmytro Sen" , "Ambari" Date: Mon, 20 Apr 2015 15:16:41 -0000 Message-ID: <20150420151641.2948.8552@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Dmytro Sen" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/33361/ X-Sender: "Dmytro Sen" Reply-To: "Dmytro Sen" X-ReviewRequest-Repository: ambari --===============0280225378490639978== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33361/ ----------------------------------------------------------- Review request for Ambari, Myroslav Papirkovskyy and Srimanth Gunturi. Bugs: AMBARI-10602 https://issues.apache.org/jira/browse/AMBARI-10602 Repository: ambari Description ------- Reviewing HDFS recommendation code for namenode_heapsize, namenode_opt_newsize and namenode_opt_maxnewsize, it looks like the calculations are not taking into account the number of datanodes and disks per datanode. HDFS recommendations currently gives the following output "configurations": { "hadoop-env": { "properties": { "namenode_heapsize": "1024", "namenode_opt_maxnewsize": "256", "namenode_opt_newsize": "256" }, "property_attributes": { "namenode_heapsize": { "maximum": "2887" }, "dtnode_heapsize": { "maximum": "2887" } } }, Diffs ----- ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 860f6a2 ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py c0e5351 ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py 1f5549b ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 09a1f12 Diff: https://reviews.apache.org/r/33361/diff/ Testing ------- ---------------------------------------------------------------------- Ran 263 tests in 8.238s OK ---------------------------------------------------------------------- Total run:728 Total errors:0 Total failures:0 OK Thanks, Dmytro Sen --===============0280225378490639978==--