Return-Path: 
 <dev-return-67317-apmail-ambari-dev-archive=ambari.apache.org@ambari.apache.org>
X-Original-To: apmail-ambari-dev-archive@www.apache.org
Delivered-To: apmail-ambari-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 38B9417EAC
	for <apmail-ambari-dev-archive@www.apache.org>;
 Sun, 19 Apr 2015 00:01:23 +0000 (UTC)
Received: (qmail 31125 invoked by uid 500); 19 Apr 2015 00:01:23 -0000
Delivered-To: apmail-ambari-dev-archive@ambari.apache.org
Received: (qmail 31091 invoked by uid 500); 19 Apr 2015 00:01:23 -0000
Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@ambari.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@ambari.apache.org>
List-Post: <mailto:dev@ambari.apache.org>
List-Id: <dev.ambari.apache.org>
Reply-To: dev@ambari.apache.org
Delivered-To: mailing list dev@ambari.apache.org
Received: (qmail 31072 invoked by uid 99); 19 Apr 2015 00:01:22 -0000
Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 19 Apr 2015 00:01:22 +0000
Received: from reviews.apache.org (localhost [127.0.0.1])
	by reviews.apache.org (Postfix) with ESMTP id 74F461CC03A;
	Sun, 19 Apr 2015 00:01:24 +0000 (UTC)
Content-Type: multipart/alternative;
 boundary="===============8231450003733151061=="
MIME-Version: 1.0
Subject: Re: Review Request 33264: AMBARI-10523 : Add support of Ranger KMS to
 Ambari
From: "Alejandro Fernandez" <afernandez@hortonworks.com>
To: "Alejandro Fernandez" <afernandez@hortonworks.com>,
 "Giridharan Kesavan" <gkesavan@apache.org>,
 "Sumit Mohanty" <smohanty@hortonworks.com>,
 "Yusaku Sako" <yusaku@hortonworks.com>
Cc: "Gautam Borad" <gborad@gmail.com>, "Ambari" <dev@ambari.apache.org>
Date: Sun, 19 Apr 2015 00:01:24 -0000
Message-ID: <20150419000124.1422.41351@reviews.apache.org>
X-ReviewBoard-URL: https://reviews.apache.org/
Auto-Submitted: auto-generated
Sender: "Alejandro Fernandez" <noreply@reviews.apache.org>
X-ReviewGroup: Ambari
X-ReviewRequest-URL: https://reviews.apache.org/r/33264/
X-Sender: "Alejandro Fernandez" <noreply@reviews.apache.org>
References: <20150416151049.1421.99745@reviews.apache.org>
In-Reply-To: <20150416151049.1421.99745@reviews.apache.org>
Reply-To: "Alejandro Fernandez" <afernandez@hortonworks.com>
X-ReviewRequest-Repository: ambari

--===============8231450003733151061==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33264/#review80621
-----------------------------------------------------------


Overall, this is pretty good.


ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/metainfo.xml
<https://reviews.apache.org/r/33264/#comment130723>

    Is there a corresponding component in hdp-select for this? If yes, then versionAdvertised = true confirms this.



ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py
<https://reviews.apache.org/r/33264/#comment130724>

    We should use named imports since it makes it easier to find where libs come from.



ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_server.py
<https://reviews.apache.org/r/33264/#comment130725>

    How will this component be updated during a Rolling Upgrade? If it already has a component in hdp-select, then we need to call "hdp-select set <component_name> <version>" here. See other components for reference. Also, it will need to be added to the upgrade pack, upgrade-2.3.xml



ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_service.py
<https://reviews.apache.org/r/33264/#comment130726>

    Use named imports.



ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_service.py
<https://reviews.apache.org/r/33264/#comment130727>

    Is it safer to first do a kill -15. May want to try using shell.kill_process_with_children(...)



ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py
<https://reviews.apache.org/r/33264/#comment130729>

    Just check if > 0



ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/service_check.py
<https://reviews.apache.org/r/33264/#comment130730>

    Use named imports, looks like only Logger, shell, and ComponentIsNotRunning are needed.


- Alejandro Fernandez


On April 16, 2015, 3:10 p.m., Gautam Borad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33264/
> -----------------------------------------------------------
> 
> (Updated April 16, 2015, 3:10 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Giridharan Kesavan, Sumit Mohanty, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-10523
>     https://issues.apache.org/jira/browse/AMBARI-10523
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Ranger KMS should be available as a service to be installed/managed from Ambari.
> User will be able to add a new service "Ranger KMS" and there will be one Server component in the service.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/alerts.json PRE-CREATION 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-acls.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-env.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-log4j.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-properties.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-site.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/metainfo.xml PRE-CREATION 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_server.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_service.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/service_check.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/role_command_order.json ead3dd4 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER_KMS/metainfo.xml PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/33264/diff/
> 
> 
> Testing
> -------
> 
> Tested adding the Ranger KMS on an CentOS6 instance.
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>


--===============8231450003733151061==--