Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 68C2817ED6 for ; Tue, 14 Apr 2015 15:19:03 +0000 (UTC) Received: (qmail 64684 invoked by uid 500); 14 Apr 2015 15:18:57 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 64657 invoked by uid 500); 14 Apr 2015 15:18:57 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 64643 invoked by uid 99); 14 Apr 2015 15:18:56 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 14 Apr 2015 15:18:56 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id E116E1D432E; Tue, 14 Apr 2015 15:18:57 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6698936311000026512==" MIME-Version: 1.0 Subject: Re: Review Request 33172: UPGRADE: Due to changes in Ambari API some response validations should be allowed with warning message From: "Vitalyi Brodetskyi" To: "Vitalyi Brodetskyi" Cc: "Dmitro Lisnichenko" , "Ambari" Date: Tue, 14 Apr 2015 15:18:57 -0000 Message-ID: <20150414151857.14115.28243@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Vitalyi Brodetskyi" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/33172/ X-Sender: "Vitalyi Brodetskyi" References: <20150414151807.31554.34711@reviews.apache.org> In-Reply-To: <20150414151807.31554.34711@reviews.apache.org> Reply-To: "Vitalyi Brodetskyi" X-ReviewRequest-Repository: ambari --===============6698936311000026512== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33172/#review80028 ----------------------------------------------------------- Ship it! Ship It! - Vitalyi Brodetskyi On Квітень 14, 2015, 3:18 після полудня, Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33172/ > ----------------------------------------------------------- > > (Updated Квітень 14, 2015, 3:18 після полудня) > > > Review request for Ambari and Vitalyi Brodetskyi. > > > Bugs: branch-2.0.maint > https://issues.apache.org/jira/browse/branch-2.0.maint > > > Repository: ambari > > > Description > ------- > > upgradeHelper use well old realization of curl via shell execute. And to handle response errors use some kind of validation of response. For new releases of Ambari response content could be changed from time to time. We need to add some "soft" validation without generation error and just warn user about unexpected response. > > > Diffs > ----- > > ambari-server/src/main/python/upgradeHelper.py 11292e9 > ambari-server/src/test/python/TestUpgradeHelper.py 2f47620 > > Diff: https://reviews.apache.org/r/33172/diff/ > > > Testing > ------- > > ---------------------------------------------------------------------- > Ran 262 tests in 6.250s > > OK > ---------------------------------------------------------------------- > Total run:641 > Total errors:0 > Total failures:0 > OK > > > Thanks, > > Dmitro Lisnichenko > > --===============6698936311000026512==--