Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ambari.apache.org
Content-Type: multipart/alternative;
 boundary="===============6832804045116310774=="
MIME-Version: 1.0
Subject: Re: Review Request 33097: Add Microsoft SQL Server support for Ambari
From: "Florian Barca" <fbarca@hortonworks.com>
To: "Alejandro Fernandez" <afernandez@hortonworks.com>,
 "Mahadev Konar" <mahadev@apache.org>,
 "Florian Barca" <fbarca@hortonworks.com>,
 "Eugene Chekanskiy" <echekanskiy@hortonworks.com>
Cc: "Jayush Luniya" <jluniya@hortonworks.com>,
 "Ambari" <dev@ambari.apache.org>
Date: Mon, 13 Apr 2015 15:44:33 -0000
Message-ID: <20150413154433.14114.61853@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Florian Barca" <noreply@reviews.apache.org>
References: <20150410224032.1488.89174@reviews.apache.org>
In-Reply-To: <20150410224032.1488.89174@reviews.apache.org>
Reply-To: "Florian Barca" <fbarca@hortonworks.com>

--===============6832804045116310774==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33097/#review79884
-----------------------------------------------------------


ambari-server/src/main/python/ambari_server/serverConfiguration.py
<https://reviews.apache.org/r/33097/#comment129468>

    Issue #2: Modification of the public interface, from sqlserver to mssql. The rationale is not obvious.


- Florian Barca


On April 10, 2015, 10:40 p.m., Jayush Luniya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33097/
> -----------------------------------------------------------
> 
> (Updated April 10, 2015, 10:40 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Eugene Chekanskiy, Florian Barca, and Mahadev Konar.
> 
> 
> Bugs: AMBARI-10448
>     https://issues.apache.org/jira/browse/AMBARI-10448
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add Microsoft SQL Server as a database option 
> Steps are similar to those documented in section "Using Non-Default Databases - Ambari" in http://docs.hortonworks.com/HDPDocuments/Ambari-1.7.0.0/AMBARI_DOC_SUITE/index.html#Item16
> Updated server/agent unit tests to pass on Mac.
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/test/python/resource_management/TestRepositoryResource.py 0539d25 
>   ambari-server/src/main/python/ambari-server.py 70c4232 
>   ambari-server/src/main/python/ambari_server/dbConfiguration.py 5e26096 
>   ambari-server/src/main/python/ambari_server/dbConfiguration_linux.py e59f1ed 
>   ambari-server/src/main/python/ambari_server/dbConfiguration_windows.py f34caeb 
>   ambari-server/src/main/python/ambari_server/serverConfiguration.py c8eebbf 
>   ambari-server/src/test/python/TestAmbariServer.py 35cd5a5 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_client.py 370aca0 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py 36c942e 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_regionserver.py 8a79701 
>   ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_service_check.py 8470269 
> 
> Diff: https://reviews.apache.org/r/33097/diff/
> 
> 
> Testing
> -------
> 
> - End to end deployment of HDFS + ZK on Linux.
> - mvn clean test
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ....................................... SUCCESS [3.240s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.030s]
> [INFO] Ambari Web ........................................ SUCCESS [38.523s]
> [INFO] Ambari Views ...................................... SUCCESS [1.875s]
> [INFO] Ambari Admin View ................................. SUCCESS [8.648s]
> [INFO] Ambari Metrics Common ............................. SUCCESS [1.361s]
> [INFO] Ambari Server ..................................... SUCCESS [51.414s]
> [INFO] Ambari Agent ...................................... SUCCESS [11.414s]
> [INFO] Ambari Client ..................................... SUCCESS [0.025s]
> [INFO] Ambari Python Client .............................. SUCCESS [0.244s]
> [INFO] Ambari Groovy Client .............................. SUCCESS [9.676s]
> [INFO] Ambari Shell ...................................... SUCCESS [0.025s]
> [INFO] Ambari Python Shell ............................... SUCCESS [0.037s]
> [INFO] Ambari Groovy Shell ............................... SUCCESS [6.494s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 2:13.732s
> [INFO] Finished at: Fri Apr 10 15:28:16 PDT 2015
> [INFO] Final Memory: 78M/1665M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Jayush Luniya
> 
>


--===============6832804045116310774==--