Return-Path: X-Original-To: apmail-ambari-dev-archive@www.apache.org Delivered-To: apmail-ambari-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4C3D9173C9 for ; Fri, 10 Apr 2015 21:58:26 +0000 (UTC) Received: (qmail 96235 invoked by uid 500); 10 Apr 2015 21:58:26 -0000 Delivered-To: apmail-ambari-dev-archive@ambari.apache.org Received: (qmail 96205 invoked by uid 500); 10 Apr 2015 21:58:26 -0000 Mailing-List: contact dev-help@ambari.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ambari.apache.org Delivered-To: mailing list dev@ambari.apache.org Received: (qmail 96189 invoked by uid 99); 10 Apr 2015 21:58:25 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 10 Apr 2015 21:58:25 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 668451D786D; Fri, 10 Apr 2015 21:58:27 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7588531076728071429==" MIME-Version: 1.0 Subject: Re: Review Request 33056: Display service specific Heatmap in the respective service page From: "Jaimin Jetly" To: "Xi Wang" , "Srimanth Gunturi" , "Yusaku Sako" Cc: "Ambari" , "Jaimin Jetly" Date: Fri, 10 Apr 2015 21:58:27 -0000 Message-ID: <20150410215827.21893.24285@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Jaimin Jetly" X-ReviewGroup: Ambari X-ReviewRequest-URL: https://reviews.apache.org/r/33056/ X-Sender: "Jaimin Jetly" References: <20150410022121.1489.41037@reviews.apache.org> In-Reply-To: <20150410022121.1489.41037@reviews.apache.org> Reply-To: "Jaimin Jetly" X-ReviewRequest-Repository: ambari --===============7588531076728071429== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33056/ ----------------------------------------------------------- (Updated April 10, 2015, 9:58 p.m.) Review request for Ambari, Srimanth Gunturi, Xi Wang, and Yusaku Sako. Changes ------- Updated patch changes the metric selection link UX and makes it consistent with others. Bugs: AMBARI-10427 https://issues.apache.org/jira/browse/AMBARI-10427 Repository: ambari Description ------- As part of this ticket service specific heatmap will be shown in their respective page with a new tab "Heatmaps". (The screenshot is attached on the Jira. Also the work can be seen on the brunch server with mock data). Dashboard->Heatmaps will show system metrics heatmap Apart from this, spinner has been changed to be shown next to the Label of the heatmap rather than individual div element. Later makes the page go up and down when the spinner is shown/hidden. Diffs (updated) ----- ambari-web/app/assets/data/stacks/HDP-2.1/service_components.json 23f65f2 ambari-web/app/controllers.js 816dbf5 ambari-web/app/controllers/main/charts/heatmap.js ecc57b3 ambari-web/app/controllers/main/service/info/heatmap.js PRE-CREATION ambari-web/app/messages.js 4d7a811 ambari-web/app/models/stack_service.js 39995bb ambari-web/app/routes/main.js 5083549 ambari-web/app/styles/application.less d4725f1 ambari-web/app/templates/main/charts/heatmap.hbs e1942bd ambari-web/app/templates/main/service/item.hbs eed34f2 ambari-web/app/views.js 936b2d3 ambari-web/app/views/main/charts/heatmap.js 59b36ff ambari-web/app/views/main/charts/heatmap/heatmap_rack.js 11c4f64 ambari-web/app/views/main/service/info/heatmap_view.js PRE-CREATION ambari-web/app/views/main/service/info/menu.js bdb0e1d ambari-web/app/views/main/service/item.js db2b490 Diff: https://reviews.apache.org/r/33056/diff/ Testing ------- Tested on a live cluster, brunch server. Verified that ambari-web unit tests passes successfully with the patch Thanks, Jaimin Jetly --===============7588531076728071429==--