ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AMBARI-10639) Configuration Versions Should Be Calculated By the Database
Date Wed, 22 Apr 2015 16:39:59 GMT

    [ https://issues.apache.org/jira/browse/AMBARI-10639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14507373#comment-14507373
] 

Hudson commented on AMBARI-10639:
---------------------------------

SUCCESS: Integrated in Ambari-trunk-Commit #2404 (See [https://builds.apache.org/job/Ambari-trunk-Commit/2404/])
AMBARI-10639 - Configuration Versions Should Be Calculated By the Database (jonathanhurley)
(jhurley: http://git-wip-us.apache.org/repos/asf?p=ambari.git&a=commit&h=511b744161ea528a8c16729202eb05da4e3715ee)
* ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ConcurrentServiceConfigVersionTest.java
* ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
* ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ServiceConfigDAO.java
* ambari-server/src/test/java/org/apache/ambari/server/orm/dao/ServiceConfigDAOTest.java
* ambari-server/src/main/java/org/apache/ambari/server/state/ConfigVersionHelper.java
* ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterDAO.java
* ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/ConfigureAction.java
* ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterConfigEntity.java
* ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceConfigEntity.java


> Configuration Versions Should Be Calculated By the Database
> -----------------------------------------------------------
>
>                 Key: AMBARI-10639
>                 URL: https://issues.apache.org/jira/browse/AMBARI-10639
>             Project: Ambari
>          Issue Type: Task
>          Components: ambari-server
>    Affects Versions: 2.1.0
>            Reporter: Jonathan Hurley
>            Assignee: Jonathan Hurley
>             Fix For: 2.1.0
>
>         Attachments: AMBARI-10639.patch
>
>
> {{ConfigVersionHelper}} is used by Ambari to determine the "next" version when creating
configuration versions and service configuration versions. This presents two problems:
> - In a distributed system, have an in-memory atomic does not work. When Ambari becomes
HA aware, this will be problematic.
> - It does not support downgrading and removing the current maximum. There would need
to be code added in various places to always remember to decrement this value. The decoupled
nature is prone it error.
> Instead, this class should be removed in favor of calculate this from the database using
a max() function on the column. This will allow removal of configurations during downgrade
to properly revert to the prior configuration version.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message