ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <>
Subject [jira] [Commented] (AMBARI-10465) Create widget -> Metrics and Expression page: Misc UI tweaks
Date Tue, 14 Apr 2015 15:40:12 GMT


Hadoop QA commented on AMBARI-10465:

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results:
Console output:

This message is automatically generated.

> Create widget -> Metrics and Expression page: Misc UI tweaks
> ------------------------------------------------------------
>                 Key: AMBARI-10465
>                 URL:
>             Project: Ambari
>          Issue Type: Task
>          Components: ambari-web
>    Affects Versions: 2.1.0
>            Reporter: Andrii Tkach
>            Assignee: Andrii Tkach
>             Fix For: 2.1.0
>         Attachments: AMBARI-10465.patch, snapshot-1.png, snapshot-2.png, snapshot-3.png,
snapshot-4.png, snapshot-5.png, snapshot-6.png
> *Tweaks to be done:*
> # Rename {{Discard}} button of Expression builder to {{Reset}} and {{Save}} button to
> # Next button on this step should not be enable until all expressions are entered and
"Done button" on all expression box is clicked.
> # For Graph widget type, We need to have "label" for each expression builder and "Add
data set" button as mocked in the design mocks for graph widget type ([link|]).
Clicking on "Add data set" link should present another expression box on the page as shown
in design mockup.
> # On "Add Metric" popup window [^snapshot-4.png], Do *not* allow multiple selection.

> # On "Add Metric" popup window [^snapshot-4.png], Show displayName in the list of components
instead of actual service name. 
> # On "Add Metric" popup window [^snapshot-4.png], Show 2 options for each master component:
"All $\{MasterComponent DisplayName\}s" and "Active $\{MasterComponent DisplayName\}". Same
as designed in the mockup
> # On "Add Metric" popup window: While rendering metric names, Render *sorted* (sort by
name) list of filtered metric names. 
> # On "Add Metric" popup window [^snapshot-5.png], Lets *not disable* "select a component"
combobox and remove cancel button. Allow the user to always change component name . This should
dynamically render new list of metric names
> # Combobox for metric selection should also support filtering metrics as user types the
> # Lets make the cancel image on chosen metrics ([^snapshot-6.png]) appear only on hover.
Also not keep it red signifying something is critical or incorrect. We can use any other lighter
color (#A69B9B)  

This message was sent by Atlassian JIRA

View raw message