ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AMBARI-10309) entries, entry_labels and entry_descriptions should not be defined as a flat list
Date Thu, 02 Apr 2015 21:03:01 GMT

    [ https://issues.apache.org/jira/browse/AMBARI-10309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14393397#comment-14393397
] 

Hudson commented on AMBARI-10309:
---------------------------------

FAILURE: Integrated in Ambari-trunk-Commit #2185 (See [https://builds.apache.org/job/Ambari-trunk-Commit/2185/])
AMBARI-10309. entries, entry_labels and entry_descriptions should not be defined as a flat
list (mpapyrkovskyy via srimanth) (sgunturi: http://git-wip-us.apache.org/repos/asf?p=ambari.git&a=commit&h=19ce4a6ca8ff20ab08e67d53d1c4fe06b2745e7e)
* ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-site.xml
* ambari-server/src/main/java/org/apache/ambari/server/controller/StackConfigurationResponse.java
* ambari-server/src/main/java/org/apache/ambari/server/state/ValueAttributesInfo.java
* ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/hive-site.xml
* ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackConfigurationResourceProvider.java
* ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hdfs-site.xml
* ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java
* ambari-server/src/main/resources/properties.json
* ambari-server/src/main/java/org/apache/ambari/server/state/PropertyInfo.java
* ambari-server/src/main/java/org/apache/ambari/server/state/ValueEntryInfo.java
* ambari-server/src/main/resources/stacks/HDP/2.1/services/HIVE/configuration/hive-site.xml
* ambari-server/src/main/java/org/apache/ambari/server/controller/StackLevelConfigurationResponse.java


> entries, entry_labels and entry_descriptions should not be defined as a flat list
> ---------------------------------------------------------------------------------
>
>                 Key: AMBARI-10309
>                 URL: https://issues.apache.org/jira/browse/AMBARI-10309
>             Project: Ambari
>          Issue Type: Task
>          Components: ambari-server
>    Affects Versions: 2.1.0
>            Reporter: Myroslav Papirkovskyy
>            Assignee: Myroslav Papirkovskyy
>             Fix For: 2.1.0
>
>
> Enhanced configs has to show lists and combos which have entries. Each entry can have
a label and description. They should show up in the API as 
> {code}
> {
>   "href" : "http://c6401:8080/api/v1/stacks/HDP/versions/2.2/services/HIVE/configurations/hive.exec.orc.default.compress",
>   "StackConfigurations" : {
>     "final" : "false",
>     "property_depended_by" : [ ],
>     "property_depends_on" : [ ],
>     "property_description" : "Define the default compression codec for ORC file",
>     "property_name" : "hive.exec.orc.default.compress",
>     "property_type" : [ ],
>     "property_value" : "ZLIB",
>     "property_value_attributes" : {
>       "type" : "value-list",
>       "entries" : [
>         "ZLIB",
>         "SNAPPY"
>       ],
>       "entryLabels" : [
>         "zlib Compression Library",
>         "Snappy Compression Library"
>       ]
>     },
>     "service_name" : "HIVE",
>     "stack_name" : "HDP",
>     "stack_version" : "2.2",
>     "type" : "hive-site.xml"
>   }
> }
> {code}
> To give the above output, currently we define the config in stack as shown below. 
> {code}
>    <property>
>      <name>hive.exec.orc.default.compress</name>
>      <value>ZLIB</value>
>      <description>Define the default compression codec for ORC file</description>
>     <display-name>ORC Compression Algorithm</display-name>
>     <value-attributes>
>       <type>value-list</type>
>       <entries>ZLIB</entries>
>       <entries>SNAPPY</entries>
>       <entry_labels>zlib Compression Library</entry_labels>
>       <entry_labels>Snappy Compression Library</entry_labels>
>       <selection-cardinality>1</selection-cardinality>
>     </value-attributes>
>    </property>
> {code}
> The problem is that there is no containment for the entry, its label and its description.
Due to this, there is not structure/correlation - which might cause issues. This has to change
so that in the stack-definition it will be like
> {code}
>    <property>
>      <name>hive.exec.orc.default.compress</name>
>      <value>ZLIB</value>
>      <description>Define the default compression codec for ORC file</description>
>     <display-name>ORC Compression Algorithm</display-name>
>     <value-attributes>
>       <type>value-list</type>
>       <entries>
>         <entry>
>           <value>ZLIB</value>
>           <label>zlib Compression Library</label>
>           <description>...</description>
>         </entry>
>         <entry>
>           <value>SNAPPY</value>
>           <label>Snappy Compression Library</label>
>           <description>...</description>
>         </entry>
>       <entries>
>       <selection-cardinality>1</selection-cardinality>
>     </value-attributes>
>    </property>
> {code}
> Labels and descriptions are optional.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message