ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nate Cole" <nc...@hortonworks.com>
Subject Re: Review Request 33692: Alert Definitions That Ignore Host Cannot Be Put Into Maintenance Mode
Date Thu, 30 Apr 2015 12:21:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33692/#review82127
-----------------------------------------------------------

Ship it!


Ship It!

- Nate Cole


On April 29, 2015, 4:17 p.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33692/
> -----------------------------------------------------------
> 
> (Updated April 29, 2015, 4:17 p.m.)
> 
> 
> Review request for Ambari, Nate Cole and Tom Beerbower.
> 
> 
> Bugs: AMBARI-10851
>     https://issues.apache.org/jira/browse/AMBARI-10851
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Alert definitions that ignore the host they run one, such as NameNode HA Health, cannot
be put into maintenance mode. The listener seemed to have some incorrect logic. Instead of
using the values from the MaintenanceModeEvent, it was looking at values from each alert.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertMaintenanceModeListener.java
200a471 
>   ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/AlertMaintenanceModeListenerTest.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/33692/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message