ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Hurley" <jhur...@hortonworks.com>
Subject Review Request 33692: Alert Definitions That Ignore Host Cannot Be Put Into Maintenance Mode
Date Wed, 29 Apr 2015 20:17:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33692/
-----------------------------------------------------------

Review request for Ambari, Nate Cole and Tom Beerbower.


Bugs: AMBARI-10851
    https://issues.apache.org/jira/browse/AMBARI-10851


Repository: ambari


Description
-------

Alert definitions that ignore the host they run one, such as NameNode HA Health, cannot be
put into maintenance mode. The listener seemed to have some incorrect logic. Instead of using
the values from the MaintenanceModeEvent, it was looking at values from each alert.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertMaintenanceModeListener.java
200a471 
  ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/AlertMaintenanceModeListenerTest.java
PRE-CREATION 

Diff: https://reviews.apache.org/r/33692/diff/


Testing
-------

mvn clean test


Thanks,

Jonathan Hurley


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message