ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sid Wagle" <swa...@hortonworks.com>
Subject Review Request 33656: AMS: navigating graph time ranges are not correct
Date Wed, 29 Apr 2015 01:59:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33656/
-----------------------------------------------------------

Review request for Ambari, Jaimin Jetly, Mahadev Konar, Sumit Mohanty, and Yusaku Sako.


Bugs: AMBARI-10809
    https://issues.apache.org/jira/browse/AMBARI-10809


Repository: ambari


Description
-------

Graphs are not padding time for full range. For example: view  4 hours with a cluster is only
a few hours old. The graphs don't change even thought the APIs calls are being made. The API
should return padded 0 values (or the graph needs to display the full range).


Keep the existing API behavior of padding with zeros for missing data points so that this
has zero impact on the UI or any other third-party code using the Ambari metrics API.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsPaddingMethod.java
PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsPropertyProvider.java
d58d110 
  ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProvider.java
7f2b227 
  ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/timeline/MetricsPaddingMethodTest.java
PRE-CREATION 

Diff: https://reviews.apache.org/r/33656/diff/


Testing
-------

Verified manually, related unit tests pass.


Thanks,

Sid Wagle


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message