ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Myroslav Papirkovskyy" <mpapyrkovs...@hortonworks.com>
Subject Re: Review Request 33625: Rename of ambari_sequences.sequence_value handled inappropriately during Upgrade
Date Tue, 28 Apr 2015 12:36:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33625/#review81807
-----------------------------------------------------------

Ship it!


Ship It!

- Myroslav Papirkovskyy


On Квітень 28, 2015, 3:33 після полудня, Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33625/
> -----------------------------------------------------------
> 
> (Updated Квітень 28, 2015, 3:33 після полудня)
> 
> 
> Review request for Ambari and Myroslav Papirkovskyy.
> 
> 
> Bugs: AMBARI-10786
>     https://issues.apache.org/jira/browse/AMBARI-10786
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> It seems ambari_sequences.sequence_value was renamed in 1.7.0 but 1.5.0, 1.6.0 and 1.6.1
Catalogs all expect column name to be sequence_value
> The rename should be idempotent, this code is doomed to fail even when running upgrade
command more than once.
> org.apache.ambari.server.upgrade.UpgradeCatalog170#renameSequenceValueColumnName
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog170.java
d6d4567 
> 
> Diff: https://reviews.apache.org/r/33625/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message