ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Nettleton" <rnettle...@hortonworks.com>
Subject Re: Review Request 33590: Blueprint configuration validation fails for all password properties
Date Mon, 27 Apr 2015 18:09:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33590/#review81700
-----------------------------------------------------------

Ship it!


Ship It!

- Robert Nettleton


On April 27, 2015, 6 p.m., John Speidel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33590/
> -----------------------------------------------------------
> 
> (Updated April 27, 2015, 6 p.m.)
> 
> 
> Review request for Ambari and Robert Nettleton.
> 
> 
> Bugs: AMBARI-10750
>     https://issues.apache.org/jira/browse/AMBARI-10750
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> After my merge of AMBARI-10750, blueprint configuration validation fails if any hostgroup
contains a component for a service which has password properties in the stack.
> This is because in one code path the config property type didn't have the ".xml" extension
stripped off.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/Stack.java
82d03fd 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackTest.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/33590/diff/
> 
> 
> Testing
> -------
> 
> Functional Testing:
> - tested blueprint validation with customer blueprint
> - tested creating cluster via blueprint
> 
> Unit Tests
> - added new unit test
> - full unit tests in progress, will post results prior to merging
> 
> 
> Thanks,
> 
> John Speidel
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message