ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jaimin Jetly" <jai...@hortonworks.com>
Subject Re: Review Request 33545: Integrate service summary page and heatmap page with the active layout API
Date Sat, 25 Apr 2015 01:47:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33545/
-----------------------------------------------------------

(Updated April 25, 2015, 1:47 a.m.)


Review request for Ambari, Srimanth Gunturi, Xi Wang, and Yusaku Sako.


Bugs: AMBARI-10746
    https://issues.apache.org/jira/browse/AMBARI-10746


Repository: ambari


Description
-------

As of now layout changes like adding a new widget, editing widget definition, hiding,redordering
etc were being done to a default layout and so changes were being propogated across users.

With this patch, each user will have its own default layout which is copied from server generated
default layout to begin with. Changes done by user henceforth will be local to the user and
will not propogate to other users.


Diffs (updated)
-----

  ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/widgets.json b79c281 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/widgets.json 15b983a 
  ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/widgets.json 9721b91 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/widgets.json 19bd480 
  ambari-web/app/assets/data/widget_layouts/HBASE_HEATMAPS.json PRE-CREATION 
  ambari-web/app/assets/data/widget_layouts/HBASE_HEATMAPS_WIDGETS.json PRE-CREATION 
  ambari-web/app/assets/data/widget_layouts/HBASE_SUMMARY.json PRE-CREATION 
  ambari-web/app/assets/data/widget_layouts/HDFS_HEATMAPS.json PRE-CREATION 
  ambari-web/app/assets/data/widget_layouts/HDFS_HEATMAPS_WIDGETS.json PRE-CREATION 
  ambari-web/app/assets/data/widget_layouts/HDFS_SUMMARY.json PRE-CREATION 
  ambari-web/app/assets/data/widget_layouts/SYSTEM_HEATMAPS.json PRE-CREATION 
  ambari-web/app/assets/data/widget_layouts/SYSTEM_HEATMAPS_WIDGETS.json PRE-CREATION 
  ambari-web/app/assets/data/widget_layouts/YARN_HEATMAPS.json PRE-CREATION 
  ambari-web/app/assets/data/widget_layouts/YARN_HEATMAPS_WIDGETS.json PRE-CREATION 
  ambari-web/app/assets/data/widget_layouts/YARN_SUMMARY.json PRE-CREATION 
  ambari-web/app/controllers/main/charts/heatmap.js 8404c2a 
  ambari-web/app/controllers/main/service/info/summary.js e65b9dc 
  ambari-web/app/mixins/common/widgets/widget_section.js c8b76e9 
  ambari-web/app/utils/ajax/ajax.js cbb0021 
  ambari-web/app/views/common/widget/graph_widget_view.js 1f705fa 
  ambari-web/app/views/main/service/info/summary.js eed0629 
  ambari-web/test/controllers/main/service/info/summary_test.js c0a3fb2 

Diff: https://reviews.apache.org/r/33545/diff/


Testing
-------

Manually tested the patch on cluster.
Added/Modified unit test.
Verified existing unit test does not break with the patch:
5907 tests complete (11 seconds)
81 tests pending


Thanks,

Jaimin Jetly


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message