ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dmitro Lisnichenko" <dlysniche...@hortonworks.com>
Subject Re: Review Request 33522: RU - Install repo should batch the distribution of bits to prevent a Denial-of-Service attack
Date Fri, 24 Apr 2015 16:22:31 GMT


> On April 24, 2015, 4:19 p.m., Sumit Mohanty wrote:
> > ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java,
line 455
> > <https://reviews.apache.org/r/33522/diff/1/?file=941037#file941037line455>
> >
> >     Can you add a test (or modify existing) to test that the tasks are broken into
stages?

Sure. As of now, there is a problem that hosts versions stuck in INSTALLING state after request
is successfully complete, I'm trying to determine whether my patch contains bug or trunk is
broken. Will switch to unit test later


- Dmitro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33522/#review81491
-----------------------------------------------------------


On April 24, 2015, 3:41 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33522/
> -----------------------------------------------------------
> 
> (Updated April 24, 2015, 3:41 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Nate Cole, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-10731
>     https://issues.apache.org/jira/browse/AMBARI-10731
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Distribution of bits will call yum commands simultaneously (in this case, on 1300 hosts)
and is bound to fail for large clusters.
> Batch the distribution of bits to prevent a Denial-of-Service attack.
> 
> 
> Diffs
> -----
> 
>   ambari-server/conf/unix/ambari.properties eade91b 
>   ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
bbeca38 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
4e6877e 
>   ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java
63447ca 
> 
> Diff: https://reviews.apache.org/r/33522/diff/
> 
> 
> Testing
> -------
> 
> Tests in error: 
>   test220Cardinality(org.apache.ambari.server.api.services.KerberosServiceMetaInfoTest):
Guice provision errors:(..)
>   test220AutoDeploy(org.apache.ambari.server.api.services.KerberosServiceMetaInfoTest):
Guice provision errors:(..)
>   test220Dependencies(org.apache.ambari.server.api.services.KerberosServiceMetaInfoTest):
Guice provision errors:(..)
> 
> Tests run: 2883, Failures: 0, Errors: 3, Skipped: 17
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Views ...................................... SUCCESS [2.841s]
> [INFO] Ambari Metrics Common ............................. SUCCESS [1.521s]
> [INFO] Ambari Server ..................................... FAILURE [40:04.954s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD FAILURE
> 
> 
> The same tests are also failing on trunk
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message