ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Srimanth Gunturi" <srima...@hortonworks.com>
Subject Re: Review Request 33436: Refactor stack-config's 'property_depended_by' information into a sub-resource
Date Thu, 23 Apr 2015 19:37:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33436/#review81377
-----------------------------------------------------------


Testing out the patch and below API should have entries and they do not.

http://c6401:8080/api/v1/stacks/HDP/versions/2.3/services/HIVE/configurations/hive_txn_acid/dependencies
http://c6401:8080/api/v1/stacks/HDP/versions/2.3/services/HIVE/configurations/hive_exec_orc_storage_strategy/dependencies

- Srimanth Gunturi


On April 22, 2015, 4:36 p.m., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33436/
> -----------------------------------------------------------
> 
> (Updated April 22, 2015, 4:36 p.m.)
> 
> 
> Review request for Ambari, John Speidel and Srimanth Gunturi.
> 
> 
> Bugs: AMBARI-10658
>     https://issues.apache.org/jira/browse/AMBARI-10658
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Currently the property_depended_by information for a stack-configuration is calculated
automatically. This has to be changed so that the derived information can be got through a
sub-resource called dependencies. This will contain the same information as the configuration
does currently.
> So a GET to http://c6401:8080/api/v1/stacks/HDP/versions/2.2/services/YARN/configurations/yarn.scheduler.maximum-allocation-mb/dependencies
will give
> {
>     "property_depended_by" : [
>       {
>         "type" : "mapred-site",
>         "name" : "yarn.app.mapreduce.am.resource.mb"
>       },
>       {
>         "type" : "mapred-site",
>         "name" : "mapreduce.map.memory.mb"
>       },
>       {
>         "type" : "mapred-site",
>         "name" : "mapreduce.reduce.memory.mb"
>       }
>     ]
> }
> Additionally there should be a single API to get all the configurations, and all their
depended_by relationship sub-resources. Currently the UI calls:
> http://c6401:8080/api/v1/stacks/HDP/versions/2.3/services?StackServices/service_name.in(HDFS,MAPREDUCE2,YARN,TEZ,HIVE,HBASE,PIG,ZOOKEEPER)
> &fields=configurations/*,StackServices/config_types/*
> We should have something very similar like
> http://c6401:8080/api/v1/stacks/HDP/versions/2.3/services?StackServices/service_name.in(HDFS,MAPREDUCE2,YARN,TEZ,HIVE,HBASE,PIG,ZOOKEEPER)
> &fields=configurations/*,configurations/dependencies,StackServices/config_types/*
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
24232ba 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/StackConfigurationDependencyResourceDefinition.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/api/resources/StackConfigurationResourceDefinition.java
610f822 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/StacksService.java
c467f44 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java
7caca31 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java
828df47 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
a57a150 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/StackConfigurationDependencyRequest.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/StackConfigurationDependencyResponse.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/StackConfigurationResponse.java
bc200ff 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/StackLevelConfigurationResponse.java
42abf15 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
0b34ada 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackConfigurationDependencyResourceProvider.java
PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackConfigurationResourceProvider.java
cc624b1 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackLevelConfigurationResourceProvider.java
1e5109c 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java e2fad62

>   ambari-server/src/main/java/org/apache/ambari/server/state/PropertyDependencyInfo.java
9427dd5 
>   ambari-server/src/main/java/org/apache/ambari/server/state/PropertyInfo.java 3596487

>   ambari-server/src/main/resources/key_properties.json cd9b617 
>   ambari-server/src/main/resources/properties.json 9357be3 
>   ambari-server/src/main/resources/stacks/stack_advisor.py cfb2485 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/StackConfigurationDefinitionTest.java
PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/api/resources/StackConfigurationDependencyDefinitionTest.java
PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AbstractResourceProviderTest.java
c977067 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackConfigurationDependencyResourceProviderTest.java
PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackConfigurationResourceProviderTest.java
d673671 
> 
> Diff: https://reviews.apache.org/r/33436/diff/
> 
> 
> Testing
> -------
> 
> Added unit tests.
> unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message