ambari-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Nettleton" <rnettle...@hortonworks.com>
Subject Re: Review Request 33461: Updates Blueprint processor to properly support HA deployments for HiveServer2, Hive MetaStore, and WebHCat
Date Thu, 23 Apr 2015 16:06:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33461/
-----------------------------------------------------------

(Updated April 23, 2015, 4:06 p.m.)


Review request for Ambari, John Speidel, Mahadev Konar, and Sumit Mohanty.


Changes
-------

Updated patch to correct the comment strings mentioned in the review.


Bugs: AMBARI-10489
    https://issues.apache.org/jira/browse/AMBARI-10489


Repository: ambari


Description
-------

This patch resolves AMBARI-10489 and AMBARI-10488.

This patch includes some minor changes to the Blueprint configuration processor
  in order to support Blueprint deployments of HiveServer2, Hive MetaStore,
  and WebHCat servers in a High Availability mode.

This patch implements the following:

 - Updates the property updater implementations in the
   BlueprintConfiguration processor in order to properly handle the cases
   when more than one instance of HiveServer2, HiveMetaStore, or WebHCat
   services are included in a Blueprint.  When an HA scenario is
   detected by the Blueprint processor, multiple instances of each of
   these services is now supported.

 - Updates to the MultipleHostPropertyUpdater implementation, in
   order to properly support the syntax of the "hive.metastore.uris"
   property in hive-site, which can consist of a comma-separated
   list of thrift:// URLs.

 - Modified the updater for "hive.metastore.uris" to refer to
   the HIVE_METASTORE component, rather than HIVE_SERVER,since this
   property should point to metastore servers.

 - Implements a new PropertyUpdater, TempletonHivePropertyUpdater,
   in order to support the proper updating of the "hive.templeton.properties"
   configuration value.

 - Updates the HDP 2.2 stack defintion for Hive, such that the
   WEBHCAT_SERVER component has a new cardinality of "1+", so that
   multiple instances of this component will be allowed in a
   given cluster.

 - Implements new unit tests to verify these changes, and also updates
   existing tests to accomodate for the changes.


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
cec93bf 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/metainfo.xml fb9a596 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
aa9fa00 

Diff: https://reviews.apache.org/r/33461/diff/


Testing
-------

1. Ran ambari-server unit tests (all passing)
2. Verified that I can deploy a Hive HA cluster using a Blueprint to a 3-node cluster.  This
cluster contains two of each of the following components (HiveServer2, Hive MetaStore, WebHCat).

3. Ran a simple, single-node cluster deployment with the Ambari UI, including Hive, to make
sure my minor stack change did not break anything in the UI deployment.


Thanks,

Robert Nettleton


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message